> On Nov. 25, 2014, 3:26 p.m., Ruslan Ostafiychuk wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpFutureAndLatestTest.java, > > line 49 > > <https://reviews.apache.org/r/28424/diff/1/?file=775159#file775159line49> > > > > ELExp_FutureAndLatestTest is not deleted too
apologies , i have not been able to follow the jiras recently. Why to we need to delete the "ELExp_FutureAndLatestTest" . are they not required anymore, or these test have been consistently failing ? - samarth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28424/#review62992 ----------------------------------------------------------- On Nov. 25, 2014, 2:04 a.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28424/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 2:04 a.m.) > > > Review request for Falcon. > > > Bugs: falcon-900 > https://issues.apache.org/jira/browse/falcon-900 > > > Repository: falcon-git > > > Description > ------- > > This patch fixes checkstyle and findbugs issue. > > > Diffs > ----- > > falcon-regression/checkstyle/pom.xml 89f785f > > falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-java-header.txt > 5d5f1e3 > > falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-noframes.xsl > 4d10dd7 > falcon-regression/checkstyle/src/main/resources/falcon/checkstyle.xml > 37e01b4 > falcon-regression/checkstyle/src/main/resources/falcon/findbugs-exclude.xml > 4de6b23 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > 02f572e > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java > d81f577 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/TestEntityUtil.java > b3f4b3c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java > 5535e00 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/LineageHelper.java > 88ea42e > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/FalconClientBuilder.java > 02b7529 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java > 89c4883 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/APIResult.java > 7464e18 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntitiesResult.java > 7344d21 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java > badab3d > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java > ee98e51 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java > 21d897c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphEntity.java > d35ced6 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphResult.java > d4be61d > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java > acd7be8 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java > c5172eb > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/HadoopFileEditor.java > c544e51 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java > 6983212 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java > ee0c072 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java > 8fe10f4 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java > 8dcb202 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/FileUtil.java > 1a97e1d > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/GraphAssert.java > 9d75591 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java > bd2aaf6 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 22c34f7 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java > dd9fe5c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/LogUtil.java > ae157ad > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MatrixUtil.java > PRE-CREATION > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > c6217c1 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/TimeUtil.java > 7df4595 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > 18b54f8 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/XmlUtil.java > f0ea328 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java > cf95107 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/security/FalconAuthorizationToken.java > fa2caf9 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java > 91d8e67 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseUITestClass.java > aab3415 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntitiesPage.java > 4dbe070 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/EntityPage.java > 3b2d5d1 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/Page.java > d6b55d4 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/pages/ProcessPage.java > 9dd5be2 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java > f8ce97e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpFutureAndLatestTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELValidationsTest.java > 7555c0c > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java > f6c068d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java > 637f8a2 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java > 229dccd > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java > 031b32d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java > ced5fbf > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java > 4ba5840 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java > d066910 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java > 88cfc2f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java > bf952f7 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java > d4f31e9 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java > 871e8dc > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java > 229cdcb > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java > a219d5a > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java > d3af1c0 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > 7b3fb62 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java > 049f278 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java > 3f7258e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java > c2d8c9b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java > e3af96d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java > 5abc932 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java > f01f30e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java > 66372e9 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java > fce0bf5 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java > db40931 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java > 514bc52 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java > 5868882 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java > 143789f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java > 632d09d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java > ee5316d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java > 991732b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java > a0cd014 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java > 5c04e20 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismClusterDeleteTest.java > c601345 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismConcurrentRequestTest.java > c767649 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java > 3bbeca1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java > 1cc558e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java > ed2d9d7 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java > 63011b8 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedResumeTest.java > 79ceacc > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedScheduleTest.java > 9a32932 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java > 4784dec > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSuspendTest.java > 7de5e39 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java > 9b5d770 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java > 05b5276 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessResumeTest.java > c2b9681 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java > ce6f675 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java > 4768e68 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSuspendTest.java > 4347040 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java > b11d586 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/ProcessPartitionExpVariableTest.java > 1a3f82f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java > dac4cf6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java > e1cdab4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java > 3d471f6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java > a61b400 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java > 6e1855b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java > cc6da00 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java > 5ea6266 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java > a716e56 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java > 46019fa > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java > 2a623e6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java > 164caa5 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java > 88c26d5 > falcon-regression/pom.xml c204d14 > > Diff: https://reviews.apache.org/r/28424/diff/ > > > Testing > ------- > > I have done some testing as I made changes but complete ground was not > covered. > > > Thanks, > > Raghav Gautam > >
