----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28508/#review63221 -----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java <https://reviews.apache.org/r/28508/#comment105393> Can we move these to toString() functions in the returned objects? client/src/main/java/org/apache/falcon/client/FalconClient.java <https://reviews.apache.org/r/28508/#comment105394> Can we change entity type to the corresponding enum? client/src/main/java/org/apache/falcon/client/FalconClient.java <https://reviews.apache.org/r/28508/#comment105395> should return APIResult? client/src/main/java/org/apache/falcon/client/FalconClient.java <https://reviews.apache.org/r/28508/#comment105396> should return entity? client/src/main/java/org/apache/falcon/client/FalconClient.java <https://reviews.apache.org/r/28508/#comment105398> Fix these as well? Else, can you create a jira so that we don't lose track client/src/main/java/org/apache/falcon/client/FalconClient.java <https://reviews.apache.org/r/28508/#comment105399> remove if not required - shwethags On Nov. 27, 2014, 7:30 a.m., samar kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28508/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2014, 7:30 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-329 > https://issues.apache.org/jira/browse/FALCON-329 > > > Repository: falcon-git > > > Description > ------- > > Falcon client methods should return objects > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java c4fc20f > client/src/main/java/org/apache/falcon/client/FalconClient.java 9a286ed > > Diff: https://reviews.apache.org/r/28508/diff/ > > > Testing > ------- > > > Thanks, > > samar kumar > >
