----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28740/#review64354 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java <https://reviews.apache.org/r/28740/#comment107005> unnecessary import ? common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java <https://reviews.apache.org/r/28740/#comment107006> error message should be "creating hivemetastore client" ? common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java <https://reviews.apache.org/r/28740/#comment107007> same here. common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java <https://reviews.apache.org/r/28740/#comment107009> We should also log the deletion of each partition. If theres some issue while deleting one of the partitions, it may not be clear what is deleted and what is not. pom.xml <https://reviews.apache.org/r/28740/#comment107004> As far as i am aware, lot of issues are fixed in hive 0.13.0 & 0.13.1. Since we are changing the API's should we also consider upgrading the hive version as well ? - Suhas Vasu On Dec. 5, 2014, 4:55 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28740/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 4:55 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-419 > https://issues.apache.org/jira/browse/FALCON-419 > > > Repository: falcon-git > > > Description > ------- > > changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient. > > > Diffs > ----- > > common/pom.xml 50dd2ea > common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java > 348fac0 > common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java > c5d4705 > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java > 3216f1e > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a > pom.xml 7a8aacc > > prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java > 4ceca29 > rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0 > webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java > fcf7f96 > webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b > > webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java > d508a2d > webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4 > webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08 > > Diff: https://reviews.apache.org/r/28740/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > >
