----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28947/#review64953 -----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java <https://reviews.apache.org/r/28947/#comment107790> why try catch block has been moved out of the for loop ? There is a benefit of having it in the for loop. For eg: in partially bad setup say with second cluster is down - the tests that don't use the second cluster would go through. The change looks good for most part using cleanAllEntities is good and is risky at the same time. It is risky in the sense that bugs if arise because of this can be hard to catch. Has this been tested throughly ? - Raghav Gautam On Dec. 11, 2014, 8:39 a.m., Ruslan Ostafiychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28947/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 8:39 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-942 > https://issues.apache.org/jira/browse/FALCON-942 > > > Repository: falcon-git > > > Description > ------- > > BaseTestClass.removeBundle() replaced with CleanupUtil methods > TestngListener prints information about start/stop so we don't need this in > before/after methods > it's easier to clean base test dir in BaseTestClass constructor instead of > adding @AfterClass every time > > > Diffs > ----- > > falcon-regression/README.md 33fd7cf > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java > 10cddf0 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/KerberosHelper.java > dc3dfae > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java > 49bdf03 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java > 2a33ac1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpFutureAndLatestTest.java > c031ab6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELValidationsTest.java > 8614a9c > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java > 1317ae4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java > 9c2a42b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java > 97048b8 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java > dfd5d0b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java > da38085 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java > e99bebd > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedResumeTest.java > 669c4fa > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedScheduleTest.java > 8500d84 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedStatusTest.java > 6278513 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java > c020127 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java > 8d96741 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSuspendTest.java > 9676a30 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java > 0833f06 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java > 287572b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java > ed6523d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java > 7a4fee4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java > 79c89df > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java > 85d7134 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java > e1a4dd4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java > 74ff0b9 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java > 0fdd419 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java > f3bb4a3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > 91fbf29 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java > 2d028ac > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java > 488cf74 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java > 6b1dec3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java > 3ab375d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java > b24abe3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java > fbf856e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java > 76c9078 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java > c3699e2 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java > 39d1e52 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java > 38e1cb2 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java > bedb456 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java > 9a822ee > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java > 485d121 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java > 4bc1806 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java > ec05166 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java > a915d24 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java > 501ccb4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java > 9e802d3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismClusterDeleteTest.java > 6f0743c > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismConcurrentRequestTest.java > fe3a425 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java > b3924db > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java > 2f83483 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java > 315a9d1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java > 0bd4c31 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedResumeTest.java > 79b12f1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedScheduleTest.java > 69e8918 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java > 3c48fc4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSuspendTest.java > 9c3b1c0 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java > 9f31e84 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java > 421be1e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessResumeTest.java > c3d8c00 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java > e00b4db > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java > 6dd6341 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSuspendTest.java > 43635bf > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java > f176da7 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/ProcessPartitionExpVariableTest.java > 48459ff > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java > 32c9783 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java > 321fca1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java > 8cae1e2 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java > a72d1cc > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java > 0a638e4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java > 00d5b7d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java > 1b5750a > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java > 74275ab > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java > f5fcdee > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java > cd32ea4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java > d62d82e > > Diff: https://reviews.apache.org/r/28947/diff/ > > > Testing > ------- > > base dir deletion and entities cleanup tested > > > Thanks, > > Ruslan Ostafiychuk > >
