> On Dec. 18, 2014, 8:48 a.m., PRAGYA MITTAL wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java, > > line 167 > > <https://reviews.apache.org/r/29059/diff/2/?file=794850#file794850line167> > > > > Is cutProtocol function necessary here ?
+1 after review comments are addressed - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29059/#review65472 ----------------------------------------------------------- On Dec. 17, 2014, 8:21 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29059/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 8:21 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-948 > https://issues.apache.org/jira/browse/FALCON-948 > > > Repository: falcon-git > > > Description > ------- > > Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed > like cutting protocols from data paths, were made to make tests running, as > well as some refactoring (replacing method to HadoopUtil). > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java > 3cb4f94 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 4f9bd9d > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > 95919ee > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java > da38085 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java > e1a4dd4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java > 488cf74 > > Diff: https://reviews.apache.org/r/29059/diff/ > > > Testing > ------- > > Now both tests pass > > > Thanks, > > Paul Isaychuk > >
