Lucas,
I modified the patch to take into account your suggestion. I also
eliminated duplicate code by combining the loop for installing
auto-install bundles with the loop for installing auto-start bundles.
-> richard
Lucas Galfaso wrote:
The patch looks very useful (and whenever you commit it I will modify
the Eclipse OSGi entrypoint to use the new version.) I only have one
question would it be possible to replace
if (st.countTokens() > 0)
{
String location = null;
do
{
location = nextLocation(st);
if (location != null)
{
[...]
}
}
while (location != null);
}
with
for (String location = nextLocation(st) ; location!=null ; location =
nextLocation(st)
{
[...]
}
as I think it helps the readability.
Regards,
Lucas
On Jan 4, 2008 7:30 PM, Richard S. Hall (JIRA) <[EMAIL PROTECTED]> wrote:
[
https://issues.apache.org/jira/browse/FELIX-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556082#action_12556082
]
Richard S. Hall commented on FELIX-448:
---------------------------------------
If it wasn't clear in the above comment, I am looking for feedback. :-)
Try to modify auto-property processing in Main to make it easier for people to
re-use
-------------------------------------------------------------------------------------
Key: FELIX-448
URL: https://issues.apache.org/jira/browse/FELIX-448
Project: Felix
Issue Type: Improvement
Components: Framework
Reporter: Richard S. Hall
Priority: Minor
Attachments: FELIX-448.patch
Since we have moved auto-property processing out of the framework, people creating
custom launchers must now handle automatically installing/starting bundles
themselves. Perhaps we could modify the default launcher to better separate out
this functionality so that it can be directly re-used in other custom launcher.
Also, we need to update the embedding & launching documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
