[ 
https://issues.apache.org/jira/browse/FELIX-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569463#action_12569463
 ] 

Stefano Lenzi commented on FELIX-486:
-------------------------------------

>I think there are still some issues with this patch. Somehow the version 
>changes don't make sense to me. 
Which version in the patch doesn't look right? (The patch that I would apply is 
the #4)

>More importantly, I don't see how this patch would address the part about 
>compiling for bytecode version 1.3. Are you assuming that we just use a jdk 
>1.3 to compile when we do a release?
The goal is to release felix-1.0.4 with framework and all the bundles attached 
to it compiled with JVM bytecode version 47.0. At the moment all the project in 
the trunk are compiled to bytecode 47.0 by default. The problem arose because 
org.osgi.core,shell, and shell.tui were release with bytecode 48.0

>I would say we need a way to tell maven to compile with -source/version=1.3 
>and possibly combine this with the switch to using the foundation profile.
> Just as in the foundation profile case, however, we need a way for 
> subprojects to say they need a different set-up.
If we want to check even the JRE classpath I agree that this patch is useless, 
in fact I have created the FELIX-487 ticket.

Finally if my english is not clear you can test the problem and check the 
solution in following way(the steps are really detailed in order to have anyone 
be able to make the test).

TO FIND THE PROBLEM:
1 - Install JRE 1.3.1
2 - Download felix-1.0.3
3 - Run felix-1.0.3: felix will not run with because org.osgi.core is compiled 
with bytecode 48.0

TO FIX IT:
1 - Checkout felix from SVN
2 - Apply the patch
3 - mvn clean install for all the project (with any JDK 1.4 or above otherwise 
mvn will not run)
4 - run felix from the main with JRE 1.3.1 it WILL RUN :)

I

> Felix release conting mixed bytecode: 1.3 and 1.4, we should compile all as 
> 1.3
> -------------------------------------------------------------------------------
>
>                 Key: FELIX-486
>                 URL: https://issues.apache.org/jira/browse/FELIX-486
>             Project: Felix
>          Issue Type: Improvement
>    Affects Versions: 1.0.1, 1.0.2, 1.0.3
>            Reporter: Stefano Lenzi
>            Priority: Minor
>         Attachments: bytecode.jre13.r620538.patch, 
> bytecode.jre13.r620865.patch, bytecode.jre13.vs.SNAPSHOT.r620865.patch, 
> bytecode.jre13.vs.SNAPSHOT.r626008.patch
>
>
> I found out that the following released project:
>  - shell-1.0.0
>  - javax.servlet-1.0.0
>  - org.osgi.core-1.0.0
>  - shell.tui-1.0.0
> which are used by the felix-1.0.3 release are compiled for JRE 1.4, so we 
> ended up with a felix released which is partially compiled for JRE 1.4 and 
> for JRE 1.3.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to