[ 
https://issues.apache.org/jira/browse/FELIX-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard S. Hall resolved FELIX-484.
-----------------------------------

    Resolution: Fixed

I modified RequirementImpl.setFilter() to throw an exception. 
LocalRepositoryImpl will now ignore any resources that cause an exception 
(which should never happen) and RepositoryAdminImpl will ignore the entire 
repository file. Alin, please close this issue if you are satisfied.

> Possible NPE in BundleRepository RequirementImpl
> ------------------------------------------------
>
>                 Key: FELIX-484
>                 URL: https://issues.apache.org/jira/browse/FELIX-484
>             Project: Felix
>          Issue Type: Bug
>          Components: Bundle Repository (OBR)
>    Affects Versions: felix-1.0.0
>            Reporter: Alin Dreghiciu
>            Assignee: Richard S. Hall
>
> In case of setting an invalid syntax requirement filter in RequirementImpl 
> internal Filter (m_filter) is set to null.
> This results in NPE as soon as getFilter, isSatisfied, equals or hashcode 
> gets called.
> I think that an invalid syntax filter should re-throw 
> org.osgi.framework.InvalidSyntaxException and calling code should handle this 
> case by skipping the resource + a warning or more dramatically by failing the 
> repository parsing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to