[ 
https://issues.apache.org/jira/browse/FELIX-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679745#action_12679745
 ] 

Richard S. Hall commented on FELIX-905:
---------------------------------------

David, I applied the patch. I made some minor modifications and one major 
modification. The major modification dealt with getting the hooks. The patch 
creates a new array each time there is a request for any hook. I modified it to 
return a collection backed by an array instead. Although, now I think I might 
have been over zealous, since I don't think my approach saves anything and 
could actually be worse.

Perhaps we can change it back to your original approach later or think of a 
better approach that doesn't require that we create new object instances, 
unless something has changed. Oh well. An "A" for effort. ;-)

We will keep these issues open, since the functionality isn't complete yet.

> Felix needs an RFC 126 FindHook
> -------------------------------
>
>                 Key: FELIX-905
>                 URL: https://issues.apache.org/jira/browse/FELIX-905
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework, Specification compliance
>            Reporter: David Bosschaert
>         Attachments: rfc126_eventhook_findhook.patch
>
>
> RFC 126 defines a FindHook that Felix needs to implement.
> For more information see: 
> http://www.osgi.org/download/osgi-4.2-early-draft2.pdf

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to