[
https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712903#action_12712903
]
Derek Baum commented on FELIX-946:
----------------------------------
I have been working with this code and have made several bug fixes:
I can supply these as a diff against shell.zip attached to this issue, or when
the code is loaded in SVN, I could raise issues against each of the bugs.
Here is a brief list of the fixes I've made:
./aQute/shell/osgi/OSGiCommands.java: // DWB1: osgi:each too
verbose (formats results to System.out)
./aQute/shell/osgi/OSGiCommands.java: // DWB2:
ClassNotFoundException should be caught in convert() method
./aQute/shell/osgi/OSGiShell.java: // DWB3:
dynamically load optional framework components to reduce dependencies
./aQute/shell/osgi/OSGiShell.java: // DWB4: get() with
trailing colon causes org.osgi.framework.InvalidSyntaxException
./aQute/shell/runtime/Closure.java: // DWB5:
session.err is not redirected when creating pipeline
./aQute/shell/runtime/Closure.java: // DWB6: add 'set
-x' trace feature if echo is set
./aQute/shell/runtime/Closure.java: // DWB7: removing
variable via 'execute("name=") throws OutOfBoundsException
./aQute/shell/runtime/CommandSessionImpl.java: // DWB8: throw
IllegatlStateException if session used after closed (as per rfc132)
./aQute/shell/runtime/CommandSessionImpl.java: // DWB9: there is no API to list
all variables: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
./aQute/shell/runtime/CommandSessionImpl.java: // DWB10: add SCOPE support:
https://www.osgi.org/bugzilla/show_bug.cgi?id=51
./aQute/shell/runtime/CommandShellImpl.java: // DWB11: add removeCommand:
https://www.osgi.org/bugzilla/show_bug.cgi?id=49
./aQute/shell/runtime/CommandShellImpl.java: // DWB12: there is no API to
list commands: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
./aQute/shell/runtime/CommandShellImpl.java: // DWB13: addCommand() fails
to add static methods (if target is Class)
./aQute/shell/runtime/Parser.java: // DWB14: parser
loops if // comment at start of program
./aQute/shell/runtime/Parser.java: // DWB15: allow
program to have trailing ';'
./aQute/shell/runtime/Pipe.java: // DWB16:
redirect System.err when creating pipe
./aQute/shell/runtime/Reflective.java: // DWB16: coerce()
doesn't support static methods
./aQute/shell/runtime/Reflective.java: // DWB17: coerce()
doesn't support static void main(String[]) in rfc132
./aQute/shell/runtime/Reflective.java: // DWB18: coerce()
doesn't extract cause from InvocationTargetException
./aQute/shell/runtime/Reflective.java: // DWB19: coerce()
won't add empty array to satisfy Object[] argument
./aQute/threadio/ThreadIOImpl.java: // DWB20: ThreadIO
should check and reset IO if something (e.g. jetty) overrides
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
