[
https://issues.apache.org/jira/browse/FELIX-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718916#action_12718916
]
Felix Meschberger commented on FELIX-1194:
------------------------------------------
We have onyl changed this from "globally open" to localhost by default in
FELIX-826 for security reasons.
My opinion is to leave it at that.
I could imagine though that we extend the remote shell to support
ConfigurationAdmin configuration for easier configuration.
> ShellRemote should listen on all IPs by default
> -----------------------------------------------
>
> Key: FELIX-1194
> URL: https://issues.apache.org/jira/browse/FELIX-1194
> Project: Felix
> Issue Type: Improvement
> Components: Remote Shell
> Affects Versions: shell.remote-1.0.4
> Reporter: Jacques-Olivier Goussard
> Priority: Minor
>
> shell.remote opens a server socket listening only on IP 127.0.0.1 by default
> (if non specified in osgi.shell.telnet.ip).
> This prevents to telnet to the console on any other IP.
> The servers socket should listen on ALL ips by default and only restrict to a
> single IP if osgi.shell.telnet.ip is set.
> Proposed fix:
> In org.apache.felix.shell.remote.Listener, modify:
> m_ip = getProperty(context, "osgi.shell.telnet.ip", "127.0.0.1");
> for
> m_ip = getProperty(context, "osgi.shell.telnet.ip", null);
> and in Listener.Acceptor modify:
> Acceptor() throws IOException
> {
> m_serverSocket = new ServerSocket(m_port, 1,
> InetAddress.getByName(m_ip));
> m_serverSocket.setSoTimeout(m_soTimeout);
> }
> for
> Acceptor() throws IOException
> {
> m_serverSocket = new ServerSocket(m_port, 1, m_ip == null ? null
> : InetAddress.getByName(m_ip));
> m_serverSocket.setSoTimeout(m_soTimeout);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
