[ 
https://issues.apache.org/jira/browse/FELIX-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742747#action_12742747
 ] 

Guillaume Nodet commented on FELIX-1481:
----------------------------------------

In addition, I think fileinstall is 1.4 compatible, so we could change the 
whole substition code with something derived from:

            Matcher matcher = Pattern.compile("\\$\\{([^}]+)\\}").matcher(val);
            while (matcher.find()) {
                String rep = System.getProperty(matcher.group(1));
                if (rep != null) {
                    val = val.replace(matcher.group(0), rep);
                    matcher.reset(val);
                }
            }


> When performing variable substitution, fileinstall throws an exception if 
> there is a start or stop delimiter without the other one
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-1481
>                 URL: https://issues.apache.org/jira/browse/FELIX-1481
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>            Reporter: Guillaume Nodet
>             Fix For: fileinstall-1.4.0
>
>
> This is a real problem as there is no way to escape the delimiters currently.
> I think silently discard any malformed substitution would be much better, 
> else any value containing a '}' will cause the config to not be loaded at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to