[ 
https://issues.apache.org/jira/browse/FELIX-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756527#action_12756527
 ] 

Filippo Diotalevi commented on FELIX-1406:
------------------------------------------

Good points.

If you have time, just go ahead and upload a new version of the template with 
the 2 fixes; otherwise I'll do that later tonight or tomorrow.

> eclipse code format template does not match existing code
> ---------------------------------------------------------
>
>                 Key: FELIX-1406
>                 URL: https://issues.apache.org/jira/browse/FELIX-1406
>             Project: Felix
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Derek Baum
>            Priority: Minor
>         Attachments: ApacheFelixEclipseTemplate.xml
>
>
> The eclipse code format template 
> http://felix.apache.org/site/coding-standards.data/ApacheFelixCodingStandards.xml
> generates slightly different white space and blank line formatting than 
> existing felix code.
> Specifically:
> 1. spaces are inserted after the opening paren and before the closing paren 
> in declarations and method calls:
> int method1( String arg1 )
> {
>     if ( expr )
>     {
>         method1( arg1 );
>     }
> }
> The felix coding standards document 
> http://felix.apache.org/site/coding-standards.html does not specifically 
> specify these spaces,
> but all the examples show code formatted without them.
> 2. two blank lines are inserted after package statement and between method 
> declarations
> This actually agrees with the eclipse template, but the code I was 
> reformatting (gogo) only had one blank line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to