[
https://issues.apache.org/jira/browse/FELIX-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758769#action_12758769
]
Felix Meschberger commented on FELIX-1636:
------------------------------------------
Yes, this is currently "by-design" ;-)
The problem is how to decide whether to call the plugin directly or not ... not
sure whether it suffices it to check for an extension. Maybe yes. Maybe not.
Consider a plugin rendering information about bundles. If called directly it
renders summary information on all bundles. If addressed with a trailing "/num"
where num is the bundle number it would render details of that bundle. Both
situations should of course render the header/footer.
Patches welcome ;-)
> Html footer and header are always added to the response for a servlet plugin
> ----------------------------------------------------------------------------
>
> Key: FELIX-1636
> URL: https://issues.apache.org/jira/browse/FELIX-1636
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-2.0.0
> Reporter: Carsten Ziegeler
> Fix For: webconsole-2.0.0
>
>
> If a plugin is registered as a plain servlet, the WebConsolePluginAdapter
> wraps this servlet and handle GET requests
> Regardless of the requested uri, the html header and footer is always added
> to the response which causes messed uprequests if the servlet wants to
> generate dynamic json (or other stuff).
> I guess the easiest way is to check the extension in the
> AbstractWebConsolePlugin#doGet()
> After the check for spoolResource a check of the extension could be made - if
> no extension or htm or html, put the footer or header around. For any other
> extension just invoke render.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
