On Fri, Mar 5, 2010 at 15:57, Felix Meschberger <[email protected]> wrote:
> Hi,
>
> This patch has a few issues IMHO:
>
> On 04.03.2010 21:54, [email protected] wrote:
>> Added:
>> felix/trunk/webconsole/src/main/resources/res/ui/jquery.uuid.js
>
> For the jquery.uuid.js plugin we need the NOTICE entry and LICENSE file
>
>> - // Define a constant of that name to prevent NoClassDefFoundError in
>> - // updateFromOBR trying to load the class with RepositoryAdmin.class
>> - private static final String REPOSITORY_ADMIN_NAME =
>> "org.osgi.service.obr.RepositoryAdmin";
>
> The reason for me to define this as a string is to prevent an exception
> if the RepositoryAdmin service API cannot be imported because there is
> no API provider bundle installed.
>
Well, I'd have no problem if the class would not use the RepositoryAdmin.
Given it *is* used, using a string here does not make sense.
In addition, the webconsole starts correctly if the package is not available.
I've checked that (though I may have missed something).
>> + <a href="obr?list=a">A</a>
>
> While chances are, the label will never change, I nevertheless think, it
> is not optimal to hard code this here.
>
> This could probably be written as
>
> <a href="${pluginRoot}?list=a">A</a>
>
> to ensure the correct URL is used regardless of how the actual bundle is
> configured/set up/coded.
Yeah, makes sense.
> Also there is a function added stemming from the Mozilla project. This
> should probably also be noted in the NOTICE/LICENSE files, right ?
Will update the NOTICE/LICENSE files for this function and the jquery.uuid.js
Thx for the reminder.
> Sorry, to bother.
>
> Regards
> Felix
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
