[
https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843996#action_12843996
]
Stuart McCulloch commented on FELIX-2176:
-----------------------------------------
This patch should definitely not be applied as it stands for the following
reasons:
1) Maven best practices strongly discourage defining external repositories
in POMs, as this *will* affect all users of the plugin
2) PackageVersionAnalyzer is needed by Carlos' bundleall goal - perhaps
people don't use this goal, but removing this will break any that do
3) The patch changes the parent POM relativePath to an incorrect value
(../pom.xml which is the reactor POM, instead of ../pom/pom.xml)
Note that the copy of BND source is meant to be there during development to
allow us to test patches on top of the latest BND source
without encountering 1). When it comes to preparing a release I usually
negotiate to get the latest BND onto central, and then remove
the source from the release.
Peter is sorting out a regular update process to get BND onto central (via
oss.sonatype.org) - once it's there I can make the necessary
updates to PackageVersionAnalyzer, etc. and remove our copy of the BND source
code. Until then please don't commit these changes.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an
> accessible private repo. The bundle plugin can copy bnd into itself so users
> don't have to have peter's secret stash configured in their nexus repo
> manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep
> the copied Builder source -- plugin passes tests and appears to work without
> it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in
> src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java
> _really_ doesn't compile any more and I suspect the functionality has moved
> into bnd. However I can't actually tell what its trying to do; I commented
> it out. If this functionality is actually in bnd then removing the class
> would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
