Possible NPE for jars with null Manifest
----------------------------------------
Key: FELIX-2318
URL: https://issues.apache.org/jira/browse/FELIX-2318
Project: Felix
Issue Type: Bug
Components: File Install
Reporter: Sahoo
JarFile.getManifest() can return null, so caller must check return value for
null-ness to avoid NPE. I see two such occurrences in fileinstall:
DirectoryWatcher.java:
private Bundle installOrUpdateBundle(
String bundleLocation, BufferedInputStream is, long checksum)
throws IOException, BundleException
{
is.mark(256 * 1024);
JarInputStream jar = new JarInputStream(is);
Manifest m = jar.getManifest();
String sn =
m.getMainAttributes().getValue(Constants.BUNDLE_SYMBOLICNAME);
...
BundleTransformer.java:
Manifest m = jar.getManifest();
if (m.getMainAttributes().getValue(new
Attributes.Name("Bundle-SymbolicName")) != null)
...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
