[
https://issues.apache.org/jira/browse/FELIX-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869268#action_12869268
]
Jamie goodyear commented on FELIX-2280:
---------------------------------------
I've just completed my tests with Oracle, going to spend a little more time
with Derby tomorrow, then if all is well commit the patch. Thanks for including
the DB failure mode test, much appreciated. :)
Oracle has been tricky in the past, so I had to double check in case we had any
regressions for FELIX-2072, FELIX-2129, or FELIX-2130. Things look good so far
:) The UNDO tablespace remained essentially constant for a one hour period, and
DB service interruptions did cause passing of service between Karaf hosts. The
behavior observed when passing "ctrl-D" or "ctrl-C" to a slave process was
consistent with Karaf 1.4.0.
> To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
> -----------------------------------------------------------------------------
>
> Key: FELIX-2280
> URL: https://issues.apache.org/jira/browse/FELIX-2280
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Affects Versions: karaf-1.4.0
> Environment: All
> Reporter: Christian Müller
> Assignee: Jamie goodyear
> Attachments: FELIX-2280.patch, FELIX-2280.patch, FELIX-2280.patch,
> FELIX-2280.patch, FELIX-2280.patch
>
>
> org.apache.felix.karaf.main.DefaultJDBCLock,
> org.apache.felix.karaf.main.MySQLJDBCLock and
> org.apache.felix.karaf.main.OracleJDBCLock has to much code duplications. I
> propose a solution like in ActiveMQ [package
> org.apache.activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/].
> And we should implement some unit tests for it.
> If it's fine for you, I will try to improve this part of karaf and provide a
> patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
