[ 
https://issues.apache.org/jira/browse/FELIX-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Hall updated FELIX-2843:
-----------------------------

    Description: 
In ConfigInstaller.parsePid(String), to clear off the path extension the 
following logic is used.

String pid = path.substring(0, path.length() - 4);

This appears to be a leftover from when only .cfg (4 chars) was allowed as a 
file extension. Since .config is now a valid file extension, the above logic 
leaves ".co" on the end of the service pid that is parsed out.

This blocks configuring of services when a configuration file ending with 
.config is used. .config syntax is required if a property needs to be something 
like String[].

  was:
In ConfigInstaller.parsePid(String), to clear off the path extension the 
following logic is used.

String pid = path.substring(0, path.length() - 4);

This appears to be a leftover from when only .cfg (4 chars) was allowed as a 
file extension. Since .config is now a valid file extension, the above logic 
leaves ".co" on the end of the service pid that is parsed out.


> Parsing PID assumes last 4 chars are file extension
> ---------------------------------------------------
>
>                 Key: FELIX-2843
>                 URL: https://issues.apache.org/jira/browse/FELIX-2843
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>    Affects Versions: fileinstall-3.1.10
>            Reporter: Carl Hall
>            Priority: Blocker
>
> In ConfigInstaller.parsePid(String), to clear off the path extension the 
> following logic is used.
> String pid = path.substring(0, path.length() - 4);
> This appears to be a leftover from when only .cfg (4 chars) was allowed as a 
> file extension. Since .config is now a valid file extension, the above logic 
> leaves ".co" on the end of the service pid that is parsed out.
> This blocks configuring of services when a configuration file ending with 
> .config is used. .config syntax is required if a property needs to be 
> something like String[].

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to