[ https://issues.apache.org/jira/browse/FELIX-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288434#comment-13288434 ]
Felix Meschberger commented on FELIX-3524: ------------------------------------------ > Let me know if you think more tests have to be done. Thanks. Maybe a few tests to prove ComponentMetadata.getConfigurationPid() never returns null and always returns the expected value (also in pre-SCR-1.2 scenarios) would be helpful. It think these could be done a simple JUnit tests. > by the way, when do you plan to cut a DS release ? Real soon ... I am a bit blocked by the large concurrency issues thread started by David Jencks. I would like to finish that before cutting a release. > SCR configuration-pid from compendium 4.3 > ----------------------------------------- > > Key: FELIX-3524 > URL: https://issues.apache.org/jira/browse/FELIX-3524 > Project: Felix > Issue Type: New Feature > Components: Declarative Services (SCR), Specification compliance > Affects Versions: scr-1.6.0 > Reporter: Pierre De Rop > Assignee: Felix Meschberger > Priority: Minor > Fix For: scr-1.8.0 > > Attachments: FELIX-3524.patch, FELIX-3524.patch > > > This issue is about implementing the new "configuration-pid" component > attribute specified by the OSGi 4.3 compendium. So far, components were using > the component name in order to retrieve the component configuration from > config admin. But In the section 112.4.4, a component can now define an > optional specific configuration-pid, in order to use a PID which is different > from the component name. > I have attached to this issue a proposed candidate patch, if someone could > review it and hopefully commit it. > I have not yet made a unit test, but if my propose patch seems reasonable and > is accepted, then I will try to learn to implement the corresponding test. > Here is a brief description of the patch: > - first the parser (XmlHandler/ComponentMetaData) has been modified in order > to parse the new configiration-pid attribute from the component element (the > parsing fails if the version is not greater or equals to DS 1.2). > - next, in ComponentRegistry.java, we are now holding the mapping between > configuration pids and their respective components: a new method > getComponentHoldersByPid(String pid) method has been added, and returns the > iterator on the ComponentHolders which must be configured with the given pid. > Please see comments in patch. > - in ConfigurationSupport.java: when a configuration update is detected from > config admin, then the updated is notified to all components whose > configuration-pid are referencing the updated pid. > thanks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira