[ 
https://issues.apache.org/jira/browse/FELIX-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415417#comment-13415417
 ] 

Richard S. Hall commented on FELIX-3598:
----------------------------------------

Sorry, didn't really look closely enough. I'm not sure how this was being 
handled previously, but the commented out sections in your property value are 
not being left out of the value (i.e., you are getting "# blah" in your value). 
Not sure if they were being ignored before or not, but since we just use the 
Properties class for reading these files, I'd guess that it doesn't respect 
comments in the middle of a line continuation.

We did specifically add a check at some point to throw an exception for an 
empty package (we didn't previously do this), so maybe before you just didn't 
notice that your system bundle any issues because we just didn't report 
anything.

For example, if I modify my config properties to included comments on the 
system.packages.extra property, my system bundle ends up exporting stuff like:

osgi.wiring.package; foo 0.0.0 [UNUSED]
osgi.wiring.package; bar 0.0.0 [UNUSED]
osgi.wiring.package; # baz 0.0.0 [UNUSED]
osgi.wiring.package; woz 0.0.0 [UNUSED]

So, perhaps the advice is, don't use comments in line-continued values for 
Properties. See if that helps.
                
> framework.resolver.ResolverImpl.toStringBlame throws NullPointerException on 
> jBPM-bpmn2 5.3.0.Final activator
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3598
>                 URL: https://issues.apache.org/jira/browse/FELIX-3598
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: framework-3.0.9
>         Environment: Karaf 2.2.8
> Ubuntu 11.10 64-bit
> java version "1.6.0_31"
> Java(TM) SE Runtime Environment (build 1.6.0_31-b04)
> Java HotSpot(TM) 64-Bit Server VM (build 20.6-b01, mixed mode) 
>            Reporter: Hendy Irawan
>
> Reference:
> * https://issues.jboss.org/browse/JBPM-3715
> * 
> http://emfmodeling.blogspot.com/2012/07/jboss-jbpm-530final-problem-in-apache.html
> This is probably partially an issue with jBPM-bpmn2 5.3.0.Final bundle 
> activator, however the error message given by Felix is also not very helpful.
> {code}
> registering core  services
> core services registered
> registering compiler services
> compiler services registered
> registering api services
> registering api : org.drools.io.impl.ResourceFactoryServiceImpl@2484e723 : 
> interface org.drools.io.ResourceFactoryService
> registering api : org.drools.marshalling.impl.MarshallerProviderImpl@ea211cf 
> : interface org.drools.marshalling.MarshallerProvider
> registering api : org.drools.impl.KnowledgeBaseFactoryServiceImpl@37dc299 : 
> interface org.drools.KnowledgeBaseFactoryService
> registering api : 
> org.drools.builder.impl.KnowledgeBuilderFactoryServiceImpl@1e5003f6 : 
> interface org.drools.builder.KnowledgeBuilderFactoryService
> registering api : org.drools.marshalling.impl.MarshallerProviderImpl@ea211cf 
> : interface org.drools.marshalling.MarshallerProvider
> api drools services registered
> registering api : 
> org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl@4208719e : 
> interface org.drools.runtime.process.ProcessRuntimeFactoryService
> registering compiler : 
> org.jbpm.process.instance.ProcessRuntimeFactoryServiceImpl@4208719e : 
> interface org.drools.runtime.process.ProcessRuntimeFactoryService
> registering api : 
> org.jbpm.marshalling.impl.ProcessMarshallerFactoryServiceImpl@725bcf3a : 
> interface org.drools.marshalling.impl.ProcessMarshallerFactoryService
> registering api : 
> org.jbpm.process.builder.ProcessBuilderFactoryServiceImpl@4ca49360 : 
> interface org.drools.compiler.ProcessBuilderFactoryService
> ERROR: Bundle org.jbpm.bpmn2 [293] Error starting 
> mvn:org.jbpm/jbpm-bpmn2/5.3.0.Final (org.osgi.framework.BundleException: 
> Activator start error in bundle org.jbpm.bpmn2 [293].)
> java.lang.NullPointerException
>         at 
> org.apache.felix.framework.resolver.ResolverImpl.toStringBlame(ResolverImpl.java:1583)
>         at 
> org.apache.felix.framework.resolver.ResolverImpl.checkPackageSpaceConsistency(ResolverImpl.java:1007)
>         at 
> org.apache.felix.framework.resolver.ResolverImpl.resolve(ResolverImpl.java:171)
>         at 
> org.apache.felix.framework.Felix$FelixResolver.resolve(Felix.java:4103)
>         at 
> org.apache.felix.framework.ModuleImpl.searchDynamicImports(ModuleImpl.java:1412)
>         at 
> org.apache.felix.framework.ModuleImpl.findClassOrResourceByDelegation(ModuleImpl.java:734)
>         at 
> org.apache.felix.framework.ModuleImpl.access$400(ModuleImpl.java:71)
>         at 
> org.apache.felix.framework.ModuleImpl$ModuleClassLoader.loadClass(ModuleImpl.java:1768)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:266)
>         at org.jbpm.osgi.bpmn2.Activator.start(Activator.java:35)
>         at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:629)
>         at org.apache.felix.framework.Felix.activateBundle(Felix.java:1842)
>         at org.apache.felix.framework.Felix.startBundle(Felix.java:1759)
>         at 
> org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1163)
>         at 
> org.apache.felix.framework.StartLevelImpl.run(StartLevelImpl.java:264)
>         at java.lang.Thread.run(Thread.java:679)
> {code}
> Sometimes (?) I have a better error:
> {code}
> 012-07-15 16:09:19,774 | ERROR | rint Extender: 1 | BlueprintContainerImpl    
>        | 9 - org.apache.aries.blueprint - 0.3.2 | Unable to start blueprint 
> container for bundle com.soluvas.com.soluvas.process.shell
> org.osgi.service.blueprint.container.ComponentDefinitionException: Error when 
> instanciating bean bpmRepo of class class 
> com.soluvas.process.shell.OsgiBpmRepository
>         at 
> org.apache.aries.blueprint.container.BeanRecipe.getInstance(BeanRecipe.java:271)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BeanRecipe.internalCreate(BeanRecipe.java:708)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.di.AbstractRecipe.create(AbstractRecipe.java:64)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BlueprintRepository.createInstances(BlueprintRepository.java:219)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BlueprintRepository.createAll(BlueprintRepository.java:147)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BlueprintContainerImpl.instantiateEagerComponents(BlueprintContainerImpl.java:631)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BlueprintContainerImpl.doRun(BlueprintContainerImpl.java:337)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BlueprintContainerImpl.run(BlueprintContainerImpl.java:230)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)[:1.6.0_23]
>         at 
> java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)[:1.6.0_23]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:166)[:1.6.0_23]
>         at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)[:1.6.0_23]
>         at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)[:1.6.0_23]
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)[:1.6.0_23]
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)[:1.6.0_23]
>         at java.lang.Thread.run(Thread.java:679)[:1.6.0_23]
> Caused by: java.lang.IllegalArgumentException: Unable to instantiate service 
> for Class 'org.drools.compiler.BPMN2ProcessProvider'
>         at 
> org.drools.util.ServiceRegistryImpl.get(ServiceRegistryImpl.java:162)
>         at 
> org.drools.compiler.BPMN2ProcessFactory.loadProvider(BPMN2ProcessFactory.java:28)
>         at 
> org.drools.compiler.BPMN2ProcessFactory.getBPMN2ProcessProvider(BPMN2ProcessFactory.java:20)
>         at 
> org.drools.compiler.BPMN2ProcessFactory.configurePackageBuilder(BPMN2ProcessFactory.java:11)
>         at 
> org.drools.compiler.PackageBuilder.addKnowledgeResource(PackageBuilder.java:687)
>         at 
> org.drools.builder.impl.KnowledgeBuilderImpl.add(KnowledgeBuilderImpl.java:45)
>         at 
> org.drools.builder.impl.KnowledgeBuilderImpl.add(KnowledgeBuilderImpl.java:34)
>         at 
> com.soluvas.process.shell.OsgiBpmRepository.<init>(OsgiBpmRepository.java:28)
>         at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)[:1.6.0_23]
>         at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)[:1.6.0_23]
>         at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)[:1.6.0_23]
>         at 
> java.lang.reflect.Constructor.newInstance(Constructor.java:532)[:1.6.0_23]
>         at 
> org.apache.aries.blueprint.utils.ReflectionUtils.newInstance(ReflectionUtils.java:257)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BeanRecipe.newInstance(BeanRecipe.java:842)[9:org.apache.aries.blueprint:0.3.2]
>         at 
> org.apache.aries.blueprint.container.BeanRecipe.getInstance(BeanRecipe.java:269)[9:org.apache.aries.blueprint:0.3.2]
>         ... 15 more
> Caused by: java.lang.IllegalArgumentException: Unable to instantiate 
> 'org.jbpm.bpmn2.BPMN2ProcessProviderImpl'
>         at 
> org.drools.util.ServiceRegistryImpl$ReflectionInstantiator.newInstance(ServiceRegistryImpl.java:213)
>         at 
> org.drools.util.ServiceRegistryImpl$ReflectionInstantiator.call(ServiceRegistryImpl.java:205)
>         at 
> org.drools.util.ServiceRegistryImpl.get(ServiceRegistryImpl.java:160)
>         ... 29 more
> Caused by: java.lang.NullPointerException
>         at 
> org.apache.felix.framework.resolver.ResolverImpl.toStringBlame(ResolverImpl.java:1583)
>         at 
> org.apache.felix.framework.resolver.ResolverImpl.checkPackageSpaceConsistency(ResolverImpl.java:924)
>         at 
> org.apache.felix.framework.resolver.ResolverImpl.resolve(ResolverImpl.java:171)
>         at 
> org.apache.felix.framework.Felix$FelixResolver.resolve(Felix.java:4103)
>         at 
> org.apache.felix.framework.ModuleImpl.searchDynamicImports(ModuleImpl.java:1412)
>         at 
> org.apache.felix.framework.ModuleImpl.findClassOrResourceByDelegation(ModuleImpl.java:734)
>         at 
> org.apache.felix.framework.ModuleImpl.access$400(ModuleImpl.java:71)
>         at 
> org.apache.felix.framework.ModuleImpl$ModuleClassLoader.loadClass(ModuleImpl.java:1768)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:266)[:1.6.0_23]
>         at java.lang.Class.forName0(Native Method)[:1.6.0_23]
>         at java.lang.Class.forName(Class.java:186)[:1.6.0_23]
>         at 
> org.drools.util.ServiceRegistryImpl$ReflectionInstantiator.newInstance(ServiceRegistryImpl.java:210)
>         ... 31 more
> {code}
> In Karaf 2.2.8, dev:show-tree is also not working (but I'll file this bug 
> separately on KARAF) :
> {code}
> 2012-07-15 14:10:48,870 | INFO  | l Console Thread | Console                  
>         | 36 - org.apache.karaf.shell.console - 2.2.8 | Exception caught 
> while executing command
> java.lang.ArrayIndexOutOfBoundsException: 18
>         at 
> org.apache.karaf.shell.dev.util.Import.split(Import.java:144)[18:org.apache.karaf.shell.dev:2.2.8]
>         at 
> org.apache.karaf.shell.dev.util.Import.parse(Import.java:104)[18:org.apache.karaf.shell.dev:2.2.8]
>         at 
> org.apache.karaf.shell.dev.ShowBundleTree.createNodesForImports(ShowBundleTree.java:136)[18:org.apache.karaf.shell.dev:2.2.8]
>         at 
> org.apache.karaf.shell.dev.ShowBundleTree.createTree(ShowBundleTree.java:128)[18:org.apache.karaf.shell.dev:2.2.8]
>         at 
> org.apache.karaf.shell.dev.ShowBundleTree.doExecute(ShowBundleTree.java:58)[18:org.apache.karaf.shell.dev:2.2.8]
>         at 
> org.apache.karaf.shell.dev.AbstractBundleCommand.doExecute(AbstractBundleCommand.java:61)[18:org.apache.karaf.shell.dev:2.2.8]
>         at 
> org.apache.karaf.shell.console.OsgiCommandSupport.execute(OsgiCommandSupport.java:38)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.commands.basic.AbstractCommand.execute(AbstractCommand.java:35)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.runtime.CommandProxy.execute(CommandProxy.java:78)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:474)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:400)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.runtime.Closure.execute(Closure.java:183)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.runtime.Closure.execute(Closure.java:120)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.felix.gogo.runtime.CommandSessionImpl.execute(CommandSessionImpl.java:89)[36:org.apache.karaf.shell.console:2.2.8]
>         at 
> org.apache.karaf.shell.console.jline.Console.run(Console.java:166)[36:org.apache.karaf.shell.console:2.2.8]
>         at java.lang.Thread.run(Thread.java:679)[:1.6.0_23]
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to