[
https://issues.apache.org/jira/browse/FELIX-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445258#comment-13445258
]
Robert Munteanu commented on FELIX-3358:
----------------------------------------
In reply to comment #2:
> I've applied a slightly modified version which ignores the plugin instead of
> executing it as a first step. WDYT?
I think this is a good first step. I've considered implementing a version of
the plugin based on the 'm2e compatible maven plugins' approach. However, I
recently became aware that the implementation is suboptimal when performing CLI
builds, as it considers all source files changed. [1]
I'm currently not sure what the best approach is, out of:
- using the m2e-compatible approach of a BuildContext
- using an annotation processor, which in theory has better change detection
- providing an minimal m2e connector which delegates work to the scr plugin
when needed
[1]: http://dev.eclipse.org/mhonarc/lists/m2e-dev/msg01052.html
> Enhance the maven-scr-plugin to be compatible with recent Maven/Eclipse
> integrations
> ------------------------------------------------------------------------------------
>
> Key: FELIX-3358
> URL: https://issues.apache.org/jira/browse/FELIX-3358
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Affects Versions: maven-scr-plugin-1.8.0
> Environment: Eclipse Indigo or newer
> Reporter: Robert Munteanu
> Fix For: maven-scr-plugin-1.8.2
>
> Attachments: m2e-lifecycle-mapping.diff
>
>
> With the recent changes brought to the Maven Eclipse integration, any unknown
> [0] plugins are flagged as problematic and an error is reported in the
> pom.xml . Typically this is solved by writing a thin integration layer
> between the Eclipse integration and the Maven plugin [1] or by instructing
> Eclipse to ignore some plugin executions.
> The new 1.1 version of the m2eclipse plugin will allow a Maven plugin ( with
> no links to Eclipse plugin development ) to use an enhanced API to become
> compatible out of the box with the Eclipse integration [2] .
> The maven-scr-plugin should take advantage of these new APIs to allow
> seamless integration with Eclipse.
> [0]: http://wiki.eclipse.org/M2E_plugin_execution_not_covered
> [1]: http://wiki.eclipse.org/M2E/Extension_Development
> [2]: http://wiki.eclipse.org/M2E_compatible_maven_plugins
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
