Hi, I think those were good since they hinted at potential programming issues like calling State methods in unexpected states.
Maybe IllegalStatetException is thus wrong and it should be something else. But I would prefer to keep them. Regards Felix Am 07.09.2012 um 18:17 schrieb <djen...@apache.org> <djen...@apache.org>: > Author: djencks > Date: Fri Sep 7 16:17:10 2012 > New Revision: 1382084 > > URL: http://svn.apache.org/viewvc?rev=1382084&view=rev > Log: > FELIX-3657 ComponentFactory can get service notifications, it just doesn't do > anything with them > > Modified: > > felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java > > Modified: > felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java > URL: > http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java?rev=1382084&r1=1382083&r2=1382084&view=diff > ============================================================================== > --- > felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java > (original) > +++ > felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentFactoryImpl.java > Fri Sep 7 16:17:10 2012 > @@ -277,17 +277,14 @@ public class ComponentFactoryImpl extend > > void update( DependencyManager dependencyManager, ServiceReference ref ) > { > - throw new IllegalStateException( "Should not be called" ); > } > > void invokeBindMethod( DependencyManager dependencyManager, > ServiceReference reference ) > { > - throw new IllegalStateException( "Should not be called" ); > } > > void invokeUnbindMethod( DependencyManager dependencyManager, > ServiceReference oldRef ) > { > - throw new IllegalStateException( "Should not be called" ); > } > > //---------- Component interface > >
