Hi Felix, I updated https://issues.apache.org/jira/browse/FELIX-3799 with a patch. This will sort by title.
Henry On Tue, Dec 4, 2012 at 3:43 AM, Felix Meschberger <[email protected]> wrote: > Hi Henry, > > Am 04.12.2012 um 10:25 schrieb Henry Saginor: > >> On Tue, Dec 4, 2012 at 12:44 AM, Felix Meschberger <[email protected]> >> wrote: >>> Hi, >>> >>> Am 04.12.2012 um 09:09 schrieb Henry Saginor: >>> >>>> Hi Felix, >>>> >>>> Thanks for the update. >>>> >>>> * Can't this be done similar to titles? >>> >>> What ? >> >> Oops. Sorry ... I meant translation. That's what happens when you >> respond to e-mails after midnight (my time). :) > > Ok, that would be FELIX-3800 then ;-) > >> >>> >>>> * I thought of hardcoding default category at first. But then I >>>> decided to just return null as a default and handle this by displaying >>>> plugins without category at the top level. Basically they would >>>> display similar to the way they are now instead of, at least >>>> initially, one large category. >>> >>> I decided to create a single default category to have a cleaned-up top >>> navigation. Your orignal patch left us with almost the same number of >>> buttons (in 3+ rows) with the category buttons interspersed. >>> >>> I prefer this default category thing from a display POV. >> >> You are right. >> >>> >>>> * To make the default category configurable I was thinking of creating >>>> a service with one property. AbstractWebConsolePlugin could just >>>> reference it. This is simple. But I am not sure if there is a better >>>> way. >>> >>> I would do it like we do for the XXXProvider: The configuration is in the >>> main Web Console Configuration and is dispatched from the OsgiManagerConfig >>> object into a static field of the AbstractWebConsolePlugin. >>> >>>> * I thought ordering used to be by title. >>>> >>>> I will look into submitting additional patches for the above when I have >>>> time. >>> >>> Cool. Thanks alot. I have created the following issues, which you might >>> refer to when providing patches: >> >> I saw it. I can't promise this week. :) > > No problem. > > Regards > Felix > > >> >>> >>> * Title ordering: FELIX-3799 [1] >>> * Configurable Default Category: FELIX-3798 [2] >>> * Category Translation: FELIX-3800 [3] >>> >>> Regards >>> Felix >>> >>> [1] https://issues.apache.org/jira/browse/FELIX-3799 >>> [2] https://issues.apache.org/jira/browse/FELIX-3798 >>> [3] https://issues.apache.org/jira/browse/FELIX-3800 >>> >>>> >>>> Henry >>>> >>>> On Sun, Dec 2, 2012 at 10:50 PM, Felix Meschberger <[email protected]> >>>> wrote: >>>>> Hi >>>>> >>>>> Thanks for the patches and the issues. >>>>> >>>>> I have slightly modified them (see the issues for details) and applied >>>>> them. >>>>> >>>>> So, plugins may now be registered with a felix.webconsole.category >>>>> property (or overwrite the AbstractWebConsolePlugin.getCategory() >>>>> method). This allows the Web Console to create Menues to access the >>>>> plugins. >>>>> >>>>> Plugins without a category specified will be placed into the default >>>>> category "Main" (for now this is hard coded). >>>>> >>>>> We have a few missing links here: >>>>> >>>>> * Categories are not translated yet >>>>> * The default category is hard coded >>>>> * The plugin sort order is by URL label and not by title >>>>> >>>>> In any case, I have updated the Web Console itself to categorize its own >>>>> plugins. >>>>> >>>>> I have deployed a SNAPSHOT of this to the Apache Snapshot repository if >>>>> you want to give it a try. >>>>> >>>>> Regards >>>>> Felix >>>>> >>>>> Am 26.11.2012 um 09:50 schrieb Henry Saginor: >>>>> >>>>>> Hi Felix and everyone, >>>>>> >>>>>> I have updated both bugs. >>>>>> https://issues.apache.org/jira/browse/FELIX-3770 >>>>>> and >>>>>> https://issues.apache.org/jira/browse/FELIX-3769 >>>>>> >>>>>> Let me know if I can do anything else. >>>>>> We should probably continue relevant conversations in JIRA. >>>>>> >>>>>> Cheers, >>>>>> Henry >>>>> >>> >
