[
https://issues.apache.org/jira/browse/FELIX-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686466#comment-13686466
]
Guillaume Nodet commented on FELIX-1131:
----------------------------------------
Proposing the following patch which fixes the problem:
{code}
diff --git
a/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
b/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
index b41d900..51571cf 100644
---
a/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
+++
b/framework/src/main/java/org/apache/felix/framework/ServiceRegistrationImpl.java
@@ -165,6 +165,18 @@ class ServiceRegistrationImpl implements
ServiceRegistration
&& !((BundleReference) m_factory.getClass()
.getClassLoader()).getBundle().equals(m_bundle))
{
+ try
+ {
+ Class providedClazz = m_bundle.loadClass(clazz.getName());
+ if (providedClazz != null)
+ {
+ return providedClazz == clazz;
+ }
+ }
+ catch (ClassNotFoundException ex)
+ {
+ // Ignore and try interface class loaders.
+ }
return true;
}
{code}
> ServiceReference.isAssignableTo fails when using a factory that can not see
> the exported class and the bundle exporting the service does not have a
> direct wire to this class
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-1131
> URL: https://issues.apache.org/jira/browse/FELIX-1131
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: framework-1.6.0
> Reporter: Guillaume Nodet
> Assignee: Richard S. Hall
>
> * bundle A defines an interface R and a class S in different packages, whith
> S implementing R
> * bundle B defines a class T extending S, it has an import statement on S
> package, but not on R package
> * bundle C defines a ServiceFactory that export T service without any import
> on any package from R, S, T
> in this case, the line 426 of ServiceRegistrationImpl is executed:
> allow =
> getServiceRegistration().isClassAccessible(requestClass);
> which looks like:
> protected boolean isClassAccessible(Class clazz)
> {
> try
> {
> // Try to load from the service object or service factory class.
> Class sourceClass = (m_factory != null)
> ? m_factory.getClass() : m_svcObj.getClass();
> Class targetClass = Util.loadClassUsingClass(sourceClass,
> clazz.getName());
> return (targetClass == clazz);
> }
> catch (Exception ex)
> {
> // Ignore this and return false.
> }
> return false;
> }
> So felix checks if the classloader used to load the factory can also load the
> interface, which is not the case in my example.
> So isClassAccessible returns false and the event is not dispatched to the
> service listener.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
