[
https://issues.apache.org/jira/browse/FELIX-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727710#comment-13727710
]
Carsten Ziegeler commented on FELIX-4135:
-----------------------------------------
I finally could give this a spin and it works pretty nicely;
So minor comments.
- I'm wondering if we should return "false" from the analyzeJar method?
- I think the ds annotations are already processed by bnd, so we don't need to
process them within this plugin
- the "Service-Component" header is overwritten, maybe we should append in
order to play well with other plugins
> Bnd scrplugin contrib
> ---------------------
>
> Key: FELIX-4135
> URL: https://issues.apache.org/jira/browse/FELIX-4135
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Pierre De Rop
> Priority: Minor
> Attachments: bnd-scr-plugin.2.tgz, bnd-scr-plugin.3.tgz,
> bnd-scr-plugin.tgz, test.bndtools.scrplugin.2.tgz, test.bndtools.scrplugin.tgz
>
>
> This issue is related to the following post, which is about writing a
> bndtools plugin for the Apache Felix Scrplugin annotations:
> http://www.mail-archive.com/dev@felix.apache.org/msg29200.html
> If this may help, I have attached to this issue a simple BND plugin, which
> internally invokes the SCRDescriptorGenerator in order to generate the
> descriptors for Apache Felix Scr annotations, as well as DS 1.2 annotations
> (using the scrplugin generator).
> Basically, just adding the following parameter in a directives.bnd file
> allows to invoke the plugin:
> -plugin
> org.apache.felix.scrplugin.bnd.SCRDescriptorBndPlugin;destdir=target/classes
> I did some tests using a BND Ant task, and it seems to work, and will try to
> do a test with bndtools this week (for now I don't know how to add a plugin
> in bndtools, but I guess it's easy).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
