[ 
https://issues.apache.org/jira/browse/FELIX-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825249#comment-13825249
 ] 

Guillaume Nodet commented on FELIX-4316:
----------------------------------------

Proposed patch:
{code}
diff --git a/scr/pom.xml b/scr/pom.xml
index f89ce39..b229ebe 100644
--- a/scr/pom.xml
+++ b/scr/pom.xml
@@ -267,6 +267,17 @@
                         </Private-Package>
                         <Import-Package>
                             <!--
+                                Configuration Admin is optional and dynamic, 
but allow eager
+                                wiring by importing it
+                            -->
+                            
org.osgi.service.cm;version="[1.2,2)";resolution:=optional,
+
+                            <!--
+                                Metatype import is optional and dynamic, but 
allow eager
+                                wiring by importing it
+                            -->
+                            
org.osgi.service.metatype;version="[1.1,2)";resolution:=optional,
+                            <!--
                                 optional import for Gogo annotations 
                             -->
                             
org.apache.felix.service.command;resolution:=optional,
{code}

> Packages imported dynamically by SCR should also be imported statically with 
> an optional flag
> ---------------------------------------------------------------------------------------------
>
>                 Key: FELIX-4316
>                 URL: https://issues.apache.org/jira/browse/FELIX-4316
>             Project: Felix
>          Issue Type: Improvement
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: scr-1.8.2
>
>
> Dynamic imports can lead to deadlocks as indicated in 
> https://issues.apache.org/jira/browse/FELIX-4308.
> Having dynamic imports wired eagerly by adding optional imports on the same 
> packages lower the risk of hitting such a deadlock.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to