[ 
https://issues.apache.org/jira/browse/FELIX-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872319#comment-13872319
 ] 

Carsten Ziegeler commented on FELIX-4378:
-----------------------------------------

Looking at the code, I remember now the logic :)
If a label or description is missing, %{name}.name resp %{name}.description is 
set as the label/description - this is the old support for a single 
metatype.properties file which is maintained separately.
At the end of the generation, a new logic for supporting inlined labels and 
descriptions run which checks if all labels/descriptions are inlined. So as 
soon as it encounters a value starting with "%" it assumes the old behaviour is 
used.
We can't change the first part as we have to be compatible. But we could add a 
check whether a value for the key exists in a metatype.properties file and if 
not, switch to the inlined version and generate some default value.

Or in short :) both of your issues have the same root cause. I'll try to get 
this fixed somehow

> generate a metatype.properties file if label/description values are used on 
> @Component or @Property which don't start with %
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-4378
>                 URL: https://issues.apache.org/jira/browse/FELIX-4378
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven SCR Plugin
>            Reporter: james strachan
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin 1.15.0
>
>
> I tried using 1.15.0 of the plugin and added some textual string values 
> (which don't start with %) for label/description on @Component and @Property 
> and they get generated into the metatype.xml file as text strings.
> I was hoping the XML would use "%foo.label" and "%foo.description" then 
> generate a metatype.properties with the mapping of foo.label = "My Label" so 
> that folks can add extra languages by just adding a new metatype file?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to