[
https://issues.apache.org/jira/browse/FELIX-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878552#comment-13878552
]
David Bosschaert commented on FELIX-4353:
-----------------------------------------
I committed a fix that fixes the testRequiredExecutionEnvironment() failure:
http://svn.apache.org/viewvc?view=revision&revision=1560317
Richard, do let me know if you think the fix could be improved.
There are two additional remarks to be made about this.
1. Since the BREE matching is now done via generic capabilities and
requirements, the special BREE handling code can probably be removed from the
ResolveContextImpl? Richard, if you agree I can look into removing that stuff.
2. My fix causes an new OSGi CT failure: DivTests.testEERequirement() I *think*
that this is a CT problem and have filed a bug with the OSGi CT for this.
> [Core R5] BundleWiringTests OSGi CT test failures
> -------------------------------------------------
>
> Key: FELIX-4353
> URL: https://issues.apache.org/jira/browse/FELIX-4353
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Reporter: David Bosschaert
> Assignee: David Bosschaert
> Fix For: framework-4.4.0
>
>
> Of the OSGi CT BundleWiringTests, 3 tests are failing:
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests
> testGetWiring(org.osgi.test.cases.framework.junit.wiring.BundleWiringTests)
> junit.framework.AssertionFailedError: Resource does not equal revision
> expected:<null> but was:<505.0>
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:280)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.assertResourceEqualsRevision(BundleWiringTests.java:359)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.assertResourceEqualsRevision(BundleWiringTests.java:355)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.checkBundleWiring(BundleWiringTests.java:566)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.testGetWiring(BundleWiringTests.java:389)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:164)
> at junit.framework.TestCase.runBare(TestCase.java:130)
> at junit.framework.TestResult$1.protect(TestResult.java:106)
> at junit.framework.TestResult.runProtected(TestResult.java:124)
> at junit.framework.TestResult.run(TestResult.java:109)
> at junit.framework.TestCase.run(TestCase.java:120)
> at junit.framework.TestSuite.runTest(TestSuite.java:230)
> at junit.framework.TestSuite.run(TestSuite.java:225)
> at junit.framework.TestSuite.runTest(TestSuite.java:230)
> at junit.framework.TestSuite.run(TestSuite.java:225)
> at aQute.junit.Activator.test(Activator.java:226)
> at aQute.junit.Activator.automatic(Activator.java:118)
> at aQute.junit.Activator.run(Activator.java:59)
> testRequiredExecutionEnvironment(org.osgi.test.cases.framework.junit.wiring.BundleWiringTests)
> junit.framework.AssertionFailedError: Wrong number of ee wires:
> org.osgi.test.cases.framework.wiring.ee.tb1 [523] expected:<1> but was:<0>
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:280)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:198)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.checkOSGiEEWiring(BundleWiringTests.java:1205)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.testRequiredExecutionEnvironment(BundleWiringTests.java:1191)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:164)
> at junit.framework.TestCase.runBare(TestCase.java:130)
> at junit.framework.TestResult$1.protect(TestResult.java:106)
> at junit.framework.TestResult.runProtected(TestResult.java:124)
> at junit.framework.TestResult.run(TestResult.java:109)
> at junit.framework.TestCase.run(TestCase.java:120)
> at junit.framework.TestSuite.runTest(TestSuite.java:230)
> at junit.framework.TestSuite.run(TestSuite.java:225)
> at junit.framework.TestSuite.runTest(TestSuite.java:230)
> at junit.framework.TestSuite.run(TestSuite.java:225)
> at aQute.junit.Activator.test(Activator.java:226)
> at aQute.junit.Activator.automatic(Activator.java:118)
> at aQute.junit.Activator.run(Activator.java:59)
> testDynamicImportPackage(org.osgi.test.cases.framework.junit.wiring.BundleWiringTests)
> junit.framework.AssertionFailedError: Wrong provider expected:<null> but
> was:<553.0>
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:280)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.checkBundleWire(BundleWiringTests.java:955)
> at
> org.osgi.test.cases.framework.junit.wiring.BundleWiringTests.testDynamicImportPackage(BundleWiringTests.java:1812)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:164)
> at junit.framework.TestCase.runBare(TestCase.java:130)
> at junit.framework.TestResult$1.protect(TestResult.java:106)
> at junit.framework.TestResult.runProtected(TestResult.java:124)
> at junit.framework.TestResult.run(TestResult.java:109)
> at junit.framework.TestCase.run(TestCase.java:120)
> at junit.framework.TestSuite.runTest(TestSuite.java:230)
> at junit.framework.TestSuite.run(TestSuite.java:225)
> at junit.framework.TestSuite.runTest(TestSuite.java:230)
> at junit.framework.TestSuite.run(TestSuite.java:225)
> at aQute.junit.Activator.test(Activator.java:226)
> at aQute.junit.Activator.automatic(Activator.java:118)
> at aQute.junit.Activator.run(Activator.java:59)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
