[ 
https://issues.apache.org/jira/browse/FELIX-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899067#comment-13899067
 ] 

Dominique Pfister commented on FELIX-4422:
------------------------------------------

The start up was already asynchronous at the time I provided the patch: 
JettyService implemented Runnable [1] and a background thread was started that 
waited for interruptions to start and stop Jetty. All I did was generalizing 
this idea to perform other operations such as deploy and un-deploy on Jetty 
asynchronously.

[1] 
http://svn.apache.org/viewvc/felix/trunk/http/jetty/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java?revision=1485242&view=markup&pathrev=1496453

> Remove asynchronous starting of Jetty service
> ---------------------------------------------
>
>                 Key: FELIX-4422
>                 URL: https://issues.apache.org/jira/browse/FELIX-4422
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http-2.2.2
>            Reporter: J.W. Janssen
>             Fix For: http-2.3.0
>
>
> The Jetty bundle currently uses an {{ExecutorService}} to start Jetty in the 
> background. I'm not sure this is actually needed with the recent versions of 
> Jetty. I've did a quick test to start Jetty synchronously in the bundle 
> activator, but could not measure any significant timing differences in 
> startup times.
> A reason to change this is that it makes the start/stop behaviour bundle more 
> deterministic when using it in integration tests.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to