[ https://issues.apache.org/jira/browse/FELIX-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955590#comment-13955590 ]
J.W. Janssen commented on FELIX-4473: ------------------------------------- I've looked a bit at the patch, and it looks good! I was able to create my own connector at runtime and it was correctly picked up and started. Two remarks: # there's an unused variable ({{connectors}}) this patch introduces in {{JettyService}} which I believe is not necessary? # the default HTTP and/or HTTPS connectors are installed by default using the configuration values, which means that if I *only* want to use a {{ConnectorFactory}} I've to explicitly configure the service to *not* use the defaults. I'm not sure yet how we can change this without losing the ease of use. Any ideas? > [Jetty] Add support for Jetty Connector injection > ------------------------------------------------- > > Key: FELIX-4473 > URL: https://issues.apache.org/jira/browse/FELIX-4473 > Project: Felix > Issue Type: Task > Components: HTTP Service > Affects Versions: http-2.2.2 > Reporter: Felix Meschberger > Attachments: FELIX-4473.patch > > > As discussed on the list [1] a ConnectorFactory service is to be defined > which allows the injection of Jetty Connector objects into the running Jetty > server. > package org.apache.felix.http.jetty; > public interface ConnectorFactory { > Connector createConnector(); > } > * createConnector creates a new configured (but not started) Connector > instance on each call > * The Jetty bundle calls createConnector for each Jetty server started (for > now this is a single one). > * The Connector is added to the Jetty server and started > * When the Jetty server stops, the connector is stopped and discarded along > with the Jetty server > * When the ConnectorFactory is stopped, the Connector has to be stopped and > removed from the Jetty server > [1] http://felix.markmail.org/thread/wvnani5362kq5ynr -- This message was sent by Atlassian JIRA (v6.2#6252)