[ 
https://issues.apache.org/jira/browse/FELIX-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved FELIX-3309.
-------------------------------------

    Resolution: Fixed

Resolved in http://svn.apache.org/viewvc?view=revision&revision=1598214
No regexp used.

I also included a unit test that covers [~janstey]'s use case and a few other 
ones.

> Dashes in qualifier get replaced by periods causing framework not to start up
> -----------------------------------------------------------------------------
>
>                 Key: FELIX-3309
>                 URL: https://issues.apache.org/jira/browse/FELIX-3309
>             Project: Felix
>          Issue Type: Bug
>    Affects Versions: framework-3.0.9
>            Reporter: Jonathan Anstey
>            Assignee: David Bosschaert
>             Fix For: framework-4.6.0
>
>         Attachments: FELIX-3309.patch
>
>
> For a valid OSGi version such as 1.2.3.foo-123, the 
> org.osgi.framework.Version class was throwing an "invalid format" error:
> Could not create framework: java.lang.IllegalArgumentException: invalid format
> java.lang.IllegalArgumentException: invalid format
>       at org.osgi.framework.Version.<init>(Version.java:140)
>       at 
> org.apache.felix.framework.ExtensionManager$ExtensionManagerModule.<init>(ExtensionManager.java:628)
>       at 
> org.apache.felix.framework.ExtensionManager.<init>(ExtensionManager.java:154)
>       at org.apache.felix.framework.Felix.<init>(Felix.java:385)
>       at 
> org.apache.felix.framework.FrameworkFactory.newFramework(FrameworkFactory.java:28)
> The cause of this was that in Felix.getFrameworkVersion the '-' character in 
> the qualifier was getting replaced with a '.' so the version was changed to 
> 1.2.3.foo.123 which wasn't valid anymore. Attaching a patch shortly that 
> copies the code from VersionCleaner in the utils project to properly clean up 
> the incoming version String.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to