Yep - simple delay cures it:

        } finally {
            f.stop();
            Thread.sleep(DELAY);
            deleteDir(cacheDir);
        }

I guess cleaner, albeit more code, would be to listen for the framework shutdown event.

I'm running Win8.1, so probably different OS/thread timing accounts for why this doesn't show up on Linux

Also seeing a PackageAdminImplTest error too - now to go look into that one!

-- Rob


On 09/06/2014 13:43, Rob Walker wrote:
The line that fails is the assertion in red:


    private static void deleteDir(File root) throws IOException
    {
        if (root.isDirectory())
        {
            for (File file : root.listFiles())
            {
                deleteDir(file);
            }
        }
        assertTrue(root.delete());
    }

It looks to be failing when trying to delete the bundle JAR

** Delete : C:\Users\robw\AppData\Local\Temp\felix-cache386680184326323909.dir\b
undle0\bundle.id
** Delete : C:\Users\robw\AppData\Local\Temp\felix-cache386680184326323909.dir\b
undle0
** Delete : C:\Users\robw\AppData\Local\Temp\felix-cache386680184326323909.dir\b
undle1\bundle.info
** Delete : C:\Users\robw\AppData\Local\Temp\felix-cache386680184326323909.dir\b
undle1\version0.0\bundle.jar

I wonder if it's timing - from memory, bundle and framework stops are not waited, so there's no guarantee in this line that the framework has stopped before the attempted deletion:

120:
        } finally {
            f.stop();
            deleteDir(cacheDir);
        }

Will try adding a delay, see if that helps.

--- Rob

On 05/06/2014 18:00, Richard S. Hall wrote:
Another followup...I upgraded to the latest Maven and Java7 JDK and the framework passes.

-> richard

On 6/5/14, 08:55 , David Bosschaert wrote:
FWIW the framework tests work fine for me with Maven 3.0.5.

David

On 5 June 2014 13:51, Richard S. Hall <he...@ungoverned.org> wrote:
I do see framework failing one of its tests too...I'll try to look into it.

-> richard


On 6/5/14, 05:25 , Rob Walker wrote:
Haven't done a full trunk build in a while, am now seeing the errors noted
below using the build instructions from the Wiki.

Tried the following before emailing:

  * updated to latest mvn 3.2.1
  * blew away my ~/.m2 directory to ensure no cached nasties

I'm running JDK1.7.0_51

This is probably a case of me being an idiot developer, so feel free to
point out the error of my ways!

Cheers for any pointers

-- Rob

=======


/_Running: *mvn -Dpackaging=plugins install*_/

This yields the following failure running SCRDescriptorGeneratorTest

-------------------------------------------------------
      T E S T S
-------------------------------------------------------
    Running org.apache.felix.scrplugin.SCRDescriptorGeneratorTest
    Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
    0.172 sec <<< FA
    ILURE!

    Results :

    Tests in error:

testSimpleComponent(org.apache.felix.scrplugin.SCRDescriptorGeneratorTest):
    Un
    able to delete file:
C:\Users\robw\AppData\Local\Temp\4d3dbacb-33c6-4592-b9ad-b2
    f74b7d99fc\testComponents\SimpleComponent.class

    Tests run: 2, Failures: 0, Errors: 1, Skipped: 0

    [INFO]
------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
[INFO] OBR Maven Plugin .................................. SUCCESS
    [01:41 min]
[INFO] Maven Bundle Plugin ............................... SUCCESS
    [02:53 min]
[INFO] Descriptor Generator Implementation ............... FAILURE [
    11.969 s]
[INFO] Annotations for SCR ............................... SKIPPED [INFO] Annotations for DS ................................ SKIPPED [INFO] Maven SCR Plugin .................................. SKIPPED [INFO] SCR Ant Task ...................................... SKIPPED [INFO] Bnd SCR Plugin .................................... SKIPPED [INFO] Maven SCR Plugin/Task support reactor ............. SKIPPED [INFO] Maven OSGi Plugin ................................. SKIPPED [INFO] Apache Felix ...................................... SKIPPED
    [INFO]
------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO]
------------------------------------------------------------------------
    [INFO] Total time: 04:56 min
    [INFO] Finished at: 2014-06-05T11:12:32+02:00
    [INFO] Final Memory: 21M/52M
    [INFO]
------------------------------------------------------------------------
    [ERROR] Failed to execute goal
    org.apache.maven.plugins:maven-surefire-plugin:2.
7.2:test (default-test) on project org.apache.felix.scr.generator:
    There are tes
    t failures.
    [ERROR]
    [ERROR] Please refer to
C:\mnt\MiscProjs\felix\scrplugin\generator\target\surefi
    re-reports for the individual test results.


_/Running: *mvn -Dpackaging=bundle install*/_

Yields a build failure running the StopStartBundle test in framework,
after which all subsequent bundle builds are skipped:

-------------------------------------------------------
      T E S T S
-------------------------------------------------------
    Running org.apache.felix.framework.BootLoaderTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.172 sec
    Running org.apache.felix.framework.capabilityset.SimpleFilterTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.015 sec
    Running org.apache.felix.framework.CollisionHookTest
    Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.141 sec
    Running org.apache.felix.framework.FilterTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.016 sec
    Running org.apache.felix.framework.FrameworkVersionTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
    Running org.apache.felix.framework.PackageAdminImplTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.047 sec
    Running org.apache.felix.framework.RequirementsCapabilitiesTest
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.062 sec
    Running org.apache.felix.framework.ServiceRegistryTest
    Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.016 sec
    Running org.apache.felix.framework.StartBundleTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.015 sec
    Running org.apache.felix.framework.StartStopBundleTest
    Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
    5.016 sec <<< F
    ILURE!
    Running org.apache.felix.framework.URLHandlersTest
    Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.312 sec
    Running org.apache.felix.framework.util.EventDispatcherTest
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
    0.016 sec
    Running
org.apache.felix.framework.util.manifestparser.ManifestParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
    Running org.apache.felix.framework.util.UtilTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
    Running org.apache.felix.framework.util.WeakZipFileTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec

    Results :

    Failed tests:
testStartStopBundle(org.apache.felix.framework.StartStopBundleTest):
    null

    Tests run: 29, Failures: 1, Errors: 0, Skipped: 0

    [INFO]
------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
[INFO] OSGi R4 Foundation EE ............................. SUCCESS
    [  1.890 s]
[INFO] Servlet 2.1 API ................................... SUCCESS
    [  1.547 s]
[INFO] OSGi R4 Core Bundle ............................... SUCCESS
    [  0.938 s]
[INFO] OSGi R4 Compendium Bundle ......................... SUCCESS
    [  3.156 s]
[INFO] Apache Felix Framework ............................ FAILURE
    [  8.563 s]


Running a mvn install just in the framework dir results in same test
failing.

-- Rob


Ascert - Taking systems to the edge
r...@ascert.com
SA +27 21 300 2028
UK +44 20 7488 3470 ext 5119
www.ascert.com





--


Ascert - Taking systems to the edge
r...@ascert.com
SA +27 21 300 2028
UK +44 20 7488 3470 ext 5119
www.ascert.com

Reply via email to