I'm pretty strongly -1 on the default binary artifact including the sources. So far felix follows maven conventions more or less and this is definitely against maven conventions.
On the other hand I'm cautiously +0.5 on building an additional artifact that is the binary jar + sources. I really would think that rather than fighting maven it might be more advisable to teach bndtools about maven standards so that it can find the sources jar automatically given a binary jar. This would fix the problem for any bundle built with maven, not just felix bundles. thanks david jencks On Jun 18, 2014, at 8:33 AM, Felix Meschberger <fmesc...@adobe.com> wrote: > +1 FWIW. > > I agree that having the source within the bundles might be a nice-to-have. > AFAICT we already deploy the sources to maven and as such can download them > as dependencies. > > I would be ok if we would have a build profile which would create a > developer's artifact which embeds the sources with the binary code. But the > default IMHO should remain to be binary only. > > Regards > Felix > > Am 18.06.2014 um 16:08 schrieb Karl Pauls <karlpa...@gmail.com>: > >> Oh, I was assuming you where talking about generating maven source jars on >> release. So that will not work (I'd still be happy if somebody gets that >> one done in the parent pom). >> >> FWIW, I'm not a super big fan of shipping the source in the binaries as >> that makes them extra bloated - we should deploy/release the source.jars >> via maven and bnd should learn how to download them from the maven repo or >> at least provide a way to attach them manually without forcing the source >> to be contained in the jar (if it can't do that already). >> >> regards, >> >> Karl >> >> >> On Wed, Jun 18, 2014 at 3:39 PM, Ferry Huberts <maili...@hupie.com> wrote: >> >>> >>> >>> On 18/06/14 15:27, Karl Pauls wrote: >>> >>>> Attaching the source jars makes a lot of sense - somebody wants to take a >>>> go at our parent pom? >>>> >>>> >>> IIRC you can't do it in the parent pom. >>> You need to add >>> <_source>true</_source> >>> to the bundle plugin configurations >>> >>> >>> regards, >>>> >>>> Karl >>>> >>>> >>>> On Wed, Jun 18, 2014 at 3:18 PM, Paul Bakker <paul.bak...@luminis.eu> >>>> wrote: >>>> >>>> +1 >>>>> >>>>> I believe Maven source jars are already generated, but it would be great >>>>> to >>>>> also generate the sources in the binaries like Bndtools expects. >>>>> >>>>> Cheers, >>>>> >>>>> Paul >>>>> >>>>> >>>>> On Wed, Jun 18, 2014 at 9:11 AM, Ferry Huberts <maili...@hupie.com> >>>>> wrote: >>>>> >>>>> >>>>>> >>>>>> On 18/06/14 14:48, Raymond Auge wrote: >>>>>> >>>>>> +1 >>>>>>> >>>>>>> I find if incredibly tiring to have to fetch the source bundles for >>>>>>> libs >>>>>>> all the time. >>>>>>> >>>>>>> Meanwhile, some libs like bnd for instance, contain the sources and >>>>>>> that >>>>>>> makes them a joy to work with. >>>>>>> >>>>>>> >>>>>> >>>>>> the reason I sent this mail is that I have an insane jetty crash that I >>>>>> wanted to track down. Because no sources were included and I use many >>>>>> >>>>> felix >>>>> >>>>>> bundles with widely differing versions it became a nightmare and I just >>>>>> gave up. >>>>>> >>>>>> >>>>>> >>>>>> However, I could see a counter argument for the size of the archive >>>>>>> >>>>>> being >>>>> >>>>>> adversely affected by the inclusion of sources, particularly for those >>>>>>> small profile installations (particularly embedded). >>>>>>> >>>>>>> >>>>>>> I'm sure an acceptable solution can be found. >>>>>> >>>>>> >>>>>> >>>>>> On Wed, Jun 18, 2014 at 3:14 AM, Ferry Huberts <maili...@hupie.com> >>>>>>> wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>>> >>>>>>>> I'd like to request that the sources be added to released bundles. >>>>>>>> This makes debugging so much easier, especially when using bndtools. >>>>>>>> >>>>>>>> The bnd instruction to accomplish this (also applicable to the bundle >>>>>>>> plugin) is: >>>>>>>> -sources: true >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Ferry Huberts >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>> Ferry Huberts >>>>>> >>>>>> >>>>> >>>> >>>> >>>> >>> -- >>> Ferry Huberts >>> >> >> >> >> -- >> Karl Pauls >> karlpa...@gmail.com >> http://twitter.com/karlpauls >> http://www.linkedin.com/in/karlpauls >> https://profiles.google.com/karlpauls >
