[ https://issues.apache.org/jira/browse/FELIX-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Roduit updated FELIX-4837: ---------------------------------- Description: This a workaround of the issue that I submitted on https://bugs.openjdk.java.net/browse/JDK-8054639 The Java Web Start classloader doesn't support to have anonymous classes or enum within the shutdown hook. The patch below allows to stop all the bundles correctly when calling m_felix.stop() in the shutdown hook. Otherwise the framework throws an exception and do not call the bundle stop. This is a problem when each bundle write its preferences or state during the stop method. {code} diff --git a/framework/src/main/java/org/apache/felix/framework/Felix.java b/framework/src/main/java/org/apache/felix/framework/Felix.java index c6b305a..e44ccea 100644 --- a/framework/src/main/java/org/apache/felix/framework/Felix.java +++ b/framework/src/main/java/org/apache/felix/framework/Felix.java @@ -1023,7 +1023,7 @@ { // Spec says stop() on SystemBundle should return immediately and // shutdown framework on another thread. - new Thread(new Runnable() { + Thread t = new Thread( "FelixShutdown"){ public void run() { try @@ -1038,7 +1038,8 @@ ex); } } - }, "FelixShutdown").start(); + }; + t.start(); } } {code} was: This a workaround of the issue that I submitted on https://bugs.openjdk.java.net/browse/JDK-8054639 The Java Web Start classloader doesn't support to have anonymous classes or enum within the shutdown hook. The patch below allows to stop all the bundles correctly when calling m_felix.stop() in the shutdown hook. Otherwise the framework throws an exception and do not call the bundle stop. This is a problem when each bundle write its preferences or state during the stop method. diff --git a/framework/src/main/java/org/apache/felix/framework/Felix.java b/framework/src/main/java/org/apache/felix/framework/Felix.java index c6b305a..e44ccea 100644 --- a/framework/src/main/java/org/apache/felix/framework/Felix.java +++ b/framework/src/main/java/org/apache/felix/framework/Felix.java @@ -1023,7 +1023,7 @@ { // Spec says stop() on SystemBundle should return immediately and // shutdown framework on another thread. - new Thread(new Runnable() { + Thread t = new Thread( "FelixShutdown"){ public void run() { try @@ -1038,7 +1038,8 @@ ex); } } - }, "FelixShutdown").start(); + }; + t.start(); } } > Workaround for JNLPClassLoader in ShutdownHook > ----------------------------------------------- > > Key: FELIX-4837 > URL: https://issues.apache.org/jira/browse/FELIX-4837 > Project: Felix > Issue Type: Bug > Components: Framework > Affects Versions: framework-4.8.0 > Environment: all > Reporter: Nicolas Roduit > > This a workaround of the issue that I submitted on > https://bugs.openjdk.java.net/browse/JDK-8054639 > The Java Web Start classloader doesn't support to have anonymous classes or > enum within the shutdown hook. > The patch below allows to stop all the bundles correctly when calling > m_felix.stop() in the shutdown hook. Otherwise the framework throws an > exception and do not call the bundle stop. This is a problem when each bundle > write its preferences or state during the stop method. > {code} > diff --git a/framework/src/main/java/org/apache/felix/framework/Felix.java > b/framework/src/main/java/org/apache/felix/framework/Felix.java > index c6b305a..e44ccea 100644 > --- a/framework/src/main/java/org/apache/felix/framework/Felix.java > +++ b/framework/src/main/java/org/apache/felix/framework/Felix.java > @@ -1023,7 +1023,7 @@ > { > // Spec says stop() on SystemBundle should return immediately and > // shutdown framework on another thread. > - new Thread(new Runnable() { > + Thread t = new Thread( "FelixShutdown"){ > public void run() > { > try > @@ -1038,7 +1038,8 @@ > ex); > } > } > - }, "FelixShutdown").start(); > + }; > + t.start(); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)