[
https://issues.apache.org/jira/browse/FELIX-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Bosschaert resolved FELIX-4938.
-------------------------------------
Resolution: Fixed
Thanks! I have applied your patch. I modified it a little bit:
* I also applied the overflow checking to the serviceObjects count.
* I changed the AtomicIntegers to AtomicLongs, which means that the situation
that will trigger the exception is now extremely unlikely to occur.
You can see the commit here:
http://svn.apache.org/viewvc?view=revision&revision=1687743
> Throw an exception when service use count overflow
> --------------------------------------------------
>
> Key: FELIX-4938
> URL: https://issues.apache.org/jira/browse/FELIX-4938
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Affects Versions: framework-3.0.0, framework-3.0.1, framework-3.0.2,
> framework-3.0.3, framework-3.0.4, framework-3.0.5, framework-3.0.6,
> framework-3.0.7, framework-3.0.8, framework-3.0.9, framework-3.2.0,
> framework-3.2.1, framework-3.2.2, framework-4.0.0, framework-4.0.1,
> framework-4.0.2, framework-4.0.3, framework-4.2.0, framework-4.2.1,
> framework-4.4.0, framework-4.4.1, framework-4.6.0, framework-4.6.1,
> framework-5.0.0, framework-5.0.1, framework-5.1.0
> Reporter: Alexandre Cartapanis
> Assignee: David Bosschaert
> Priority: Minor
> Labels: easyfix
> Fix For: framework-5.1.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In class org.apache.felix.framework.ServiceRegistry, in the getService
> method, the service use count is incremented but never checked, so it could
> overflow if service is not ungeted.
> This is a known bug in equinox
> (https://bugs.eclipse.org/bugs/show_bug.cgi?id=350719)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
