[ https://issues.apache.org/jira/browse/FELIX-5212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189378#comment-15189378 ]
ASF GitHub Bot commented on FELIX-5212: --------------------------------------- GitHub user kwin opened a pull request: https://github.com/apache/felix/pull/56 FELIX-5212 clarify javadoc of element "order" in SlingFilter annotation You can merge this pull request into a Git repository by running: $ git pull https://github.com/kwin/felix FELIX-5212-extend-javadoc-of-slingfilter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/felix/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 ---- commit 272524ce17293c2ffcc5808a612358f2297b7fe2 Author: Konrad Windszus <konra...@gmx.de> Date: 2016-03-10T14:43:22Z FELIX-5212 clarify javadoc of element "order" in SlingFilter annotation ---- > Clarify that property service.ranking is generated from SlingFilter order > element > --------------------------------------------------------------------------------- > > Key: FELIX-5212 > URL: https://issues.apache.org/jira/browse/FELIX-5212 > Project: Felix > Issue Type: Improvement > Components: SCR Tooling > Affects Versions: maven-scr-plugin 1.21.0 > Reporter: Konrad Windszus > Priority: Minor > > The javadoc of the {{SlingFilter}} annotation doesn't mention that the order > field is translated into a service.ranking property (as you can see in > https://github.com/apache/felix/blob/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scrplugin/processing/SlingAnnotationProcessor.java#L181). > This is IMHO valuable information and should be added to the javadoc in > https://github.com/apache/felix/blob/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scr/annotations/sling/SlingFilter.java#L52. -- This message was sent by Atlassian JIRA (v6.3.4#6332)