[ https://issues.apache.org/jira/browse/FELIX-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197047#comment-15197047 ]
ASF GitHub Bot commented on FELIX-5217: --------------------------------------- Github user CodingFabian closed the pull request at: https://github.com/apache/felix/pull/58 > Fileinstall is handling removal of many files inefficiently > ----------------------------------------------------------- > > Key: FELIX-5217 > URL: https://issues.apache.org/jira/browse/FELIX-5217 > Project: Felix > Issue Type: Bug > Components: File Install > Reporter: Fabian Lange > Assignee: Guillaume Nodet > Fix For: fileinstall-3.5.4 > > > I am currently debugging a performance issue with file install. > The thread is very hot on: > java.util.HashMap.hash(java.lang.Object) > java.util.HashMap.put(java.lang.Object, java.lang.Object) > java.util.HashSet.add(java.lang.Object) > java.util.AbstractCollection.addAll(java.util.Collection) (line: 344) > org.apache.felix.fileinstall.internal.WatcherScanner.scan(boolean) (line: 100) > org.apache.felix.fileinstall.internal.DirectoryWatcher.run() (line: 302) > What I see in WatcherScanner, is that it potentially adds the same elements > over and over again. > While I am sure that this is not the root cause, I suggest to change the > method to avoid this. (submitting pr in a second) -- This message was sent by Atlassian JIRA (v6.3.4#6332)