[ 
https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205371#comment-15205371
 ] 

ASF GitHub Bot commented on FELIX-4009:
---------------------------------------

GitHub user stefanseifert opened a pull request:

    https://github.com/apache/felix/pull/60

    FELIX-4009 maven bundle plugin m2e integration further improvments

    *  make sure metatype xml files are exported as well & changes notified 
correctly to build context
    *  add debug logging to manifest and SCR export generation
    * add switch to turn support incremental builds on and off (default: off)
    * add detection to run incremental build only when and *.java file was 
touched

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stefanseifert/felix 
feature/FELIX-4009_m2e-improvements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/felix/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit 415422d683de65a591f63fb60b8710df00b53771
Author: sseifert <sseif...@pro-vision.de>
Date:   2016-03-21T22:38:20Z

    FELIX-4009 make sure metatype xml files are exported as well & changes 
notified correctly to build context

commit cddab03b0fd73b284f4af5ca9ed1ae4844e69b56
Author: sseifert <sseif...@pro-vision.de>
Date:   2016-03-21T22:47:16Z

    FELIX-4009 add debug logging to manifest and SCR export generation

commit d00637f66672bf531e8c082324758fc412e77262
Author: sseifert <sseif...@pro-vision.de>
Date:   2016-03-21T23:35:49Z

    FELIX-4009 add switch to turn support incremental builds on and off 
(default: off)
    add detection to run incremental build only when and *.java file was touched

----


> maven bundle plugin should be integrated directly with eclipse
> --------------------------------------------------------------
>
>                 Key: FELIX-4009
>                 URL: https://issues.apache.org/jira/browse/FELIX-4009
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.3.7
>            Reporter: Andrei Pozolotin
>            Assignee: Carsten Ziegeler
>              Labels: m2e
>             Fix For: maven-bundle-plugin-3.0.2
>
>
> Stuart:
> 1) currently, to integrate maven-bundle-plugin into m2e, one must  use tycho 
> configurator
> https://github.com/sonatype/m2eclipse-tycho
> which adds needles complexity, and makes few strange assumptions
> https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74
> which no one it seems is there to care to correct
> https://github.com/sonatype/m2eclipse-tycho/pull/8
> 2) instead, I suggest maven-bundle-plugin to provide direct integration with 
> eclipse via
> http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext
> which I would expect to be more customizable / flexible for the end user.
> I recently made similar switch with my DS plugin, and life got easier :-)
> https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin
> thanks.
> Andrei.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to