Hi Guillaume, Somehow I missed the issue being filed. I’d appreciate it if you could hold off committing this until I have affirmatively reviewed the proposal. I’ll try to get to it soon, but can’t promise.
thanks david jencks > On May 3, 2016, at 7:54 AM, Guillaume Nodet <gno...@apache.org> wrote: > > I've raised FELIX-5243 about refactoring some SCR code but haven't had any > feedback. > The commits are visible at: > https://github.com/gnodet/felix/commits/FELIX-5243 > Unless someone complains, and given it's only refactoring and should not > alter the code itself (and all tests pass), I'll push those changes later > this week. > > Cheers, > Guillaume