[
https://issues.apache.org/jira/browse/FELIX-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278862#comment-15278862
]
Thomas Watson commented on FELIX-4848:
--------------------------------------
Sorry I have not taken a closer look at this contribution. I suspect it is now
stale and cannot be applied easily. It also is likely unreasonable to ask you
to revisit this given how unresponsive we have been in getting this work
applied.
On a more cheerful note. I tried to do my own bit of clean up on the code in
FELIX-5251. Christian, not sure if you would be willing to have a look at the
current code in trunk to see if it has improved enough to make this defect
obsolete.
> Split ResolverImpl
> ------------------
>
> Key: FELIX-4848
> URL: https://issues.apache.org/jira/browse/FELIX-4848
> Project: Felix
> Issue Type: Improvement
> Components: Resolver
> Affects Versions: resolver-1.0.0
> Reporter: Christian Schneider
> Fix For: resolver-2.0.0
>
> Attachments: Dependencies in resolver package after patch.png,
> FELIX-4848-1.patch
>
>
> ResolverImpl currently contains about 2300 lines of code. That is way too big
> for a single class.
> I looked into it and found that the checkDynamicPackageSpaceConsistency and
> checkPackageSpaceConsistency methods and their dependent methods form a nice
> subset. I would move that into a class ConsistencyCheck.
> Both would share all of the inner classes of ResolverImpl but nothing else.
> So I think i would make sense to move these inner classes to separate files.
> These changes should nicely split the classes into
> ResolverImpl : 1400 lines
> ConsistencyCheck : 600 lines
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
