GitHub user set321go opened a pull request:
https://github.com/apache/felix/pull/65
Do not attempt to process files when there are none
I tried to create a ticket for this but I can't create tickets in ASF jira.
Fileinstall was surprisingly at the top of the hotspot list while profiling
today while running fileinstall 3.5.0 after upgrading to 3.5.4 there were some
improvements. Even after stretching the polling from the default 2sec to 60sec
it still used a lot of cpu. My file install directory contains 4 config files
and no subdirectories.
This change prevents `process` being called when `files` is empty which is
most of the time.
I also noticed locally that during a poll this line of code was called
multiple times (usually 4).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/set321go/felix trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 7a6bdb0895674f2359a2a05ee50f802baaa612c2
Author: Alex Edwards <[email protected]>
Date: 2016-05-13T18:33:36Z
Do not attempt to process files when there are none
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
