[ https://issues.apache.org/jira/browse/FELIX-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464698#comment-15464698 ]
David Bosschaert commented on FELIX-5338: ----------------------------------------- Good point, since this is part of the OSGi API I will discuss it within the OSGi EG, but I agree that newAdapter() - and some doc clarification - would be better. > Clarification of Converter.getAdapter() > --------------------------------------- > > Key: FELIX-5338 > URL: https://issues.apache.org/jira/browse/FELIX-5338 > Project: Felix > Issue Type: Improvement > Components: Converter > Reporter: David Leangen > > Hi! > The intent of Converter.getAdapter() is not quite clear to me. > {code} > /** > * Obtain an adapter to this converter. The adapter behaves just like > the > * converter except for the exception rules registered with is. For more > * details see the {@link Adapter} interface. > * > * @return An adapter to this converter. > */ > Adapter getAdapter(); > {code} > Is this supposed to return an *existing* Adapter? Or rather, should it return > a *new* Adapter. > My guess is the latter, and the implementation code aligns with my > expectation. However, it is not clear from the documentation or the API. > Suggestion: the method should be renamed to "newAdapter()". -- This message was sent by Atlassian JIRA (v6.3.4#6332)