[ https://issues.apache.org/jira/browse/FELIX-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873571#comment-15873571 ]
ASF GitHub Bot commented on FELIX-4837: --------------------------------------- GitHub user nroduit opened a pull request: https://github.com/apache/felix/pull/94 [FELIX-4837] Fix issue with JNLPClassLoader in ShutdownHook See https://issues.apache.org/jira/browse/FELIX-4837 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nroduit/felix FELIX-4837 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/felix/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 ---- commit da14e4ab6777f789a02a6138d7936e9d34135ff2 Author: Nicolas Roduit <nicolas.rod...@gmail.com> Date: 2017-02-19T08:31:17Z [FELIX-4837] Fix issue with JNLPClassLoader in ShutdownHook ---- > Workaround for JNLPClassLoader in ShutdownHook > ----------------------------------------------- > > Key: FELIX-4837 > URL: https://issues.apache.org/jira/browse/FELIX-4837 > Project: Felix > Issue Type: Bug > Components: Framework > Affects Versions: framework-5.0.1, framework-5.6.1 > Environment: all > Reporter: Nicolas Roduit > > This a workaround of the issue that I submitted on > https://bugs.openjdk.java.net/browse/JDK-8054639 > The Java Web Start classloader doesn't support to have anonymous classes or > enum within the shutdown hook. > The patch below allows to stop all the bundles correctly when calling > m_felix.stop() in the shutdown hook. Otherwise the framework throws an > exception and do not call the bundle stop. This is a problem when each bundle > write its preferences or state during the stop method. > {code} > diff --git a/framework/src/main/java/org/apache/felix/framework/Felix.java > b/framework/src/main/java/org/apache/felix/framework/Felix.java > index c6b305a..e44ccea 100644 > --- a/framework/src/main/java/org/apache/felix/framework/Felix.java > +++ b/framework/src/main/java/org/apache/felix/framework/Felix.java > @@ -1023,7 +1023,7 @@ > { > // Spec says stop() on SystemBundle should return immediately and > // shutdown framework on another thread. > - new Thread(new Runnable() { > + Thread t = new Thread( "FelixShutdown"){ > public void run() > { > try > @@ -1038,7 +1038,8 @@ > ex); > } > } > - }, "FelixShutdown").start(); > + }; > + t.start(); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)