[ 
https://issues.apache.org/jira/browse/FELIX-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011848#comment-16011848
 ] 

Guillaume Nodet commented on FELIX-2318:
----------------------------------------

In this case, having to use JarInputStream would force the use of an 
intermediary file to copy the content of the input stream so that it can be 
opened using a JarFile.  Supporting that correctly might be doable in a proper 
way though, and if you're willing to provide a patch, please raise a new issue 
and attach a patch or PR, I'd be happy to help reviewing it.

> Possible NPE for jars with null Manifest
> ----------------------------------------
>
>                 Key: FELIX-2318
>                 URL: https://issues.apache.org/jira/browse/FELIX-2318
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>            Reporter: Sahoo
>            Assignee: Guillaume Nodet
>             Fix For: fileinstall-3.1.0
>
>
> JarFile.getManifest() can return null, so caller must check return value for 
> null-ness to avoid NPE. I see two such occurrences in fileinstall:
> DirectoryWatcher.java:
>     private Bundle installOrUpdateBundle(
>         String bundleLocation, BufferedInputStream is, long checksum)
>         throws IOException, BundleException
>     {
>         is.mark(256 * 1024);
>         JarInputStream jar = new JarInputStream(is);
>         Manifest m = jar.getManifest();
>         String sn = 
> m.getMainAttributes().getValue(Constants.BUNDLE_SYMBOLICNAME);
> ...
> BundleTransformer.java:
>             Manifest m = jar.getManifest();
>             if (m.getMainAttributes().getValue(new 
> Attributes.Name("Bundle-SymbolicName")) != null)
>             ...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to