GitHub user drewbrokke opened a pull request:
https://github.com/apache/felix/pull/113
Fixes regression caused by FELIX-1488
If one of the three calls inside of the `delete()` method throws an
exception, the `isDeleted` field remains true, which causes some unexpected
`IllegalStateException`s.
Before the field was introduced, whenever the `isDeleted()` method was
called it would invoke `getPersistenceManager()`, which would then use the
local persistence manager to actually check to see if the configuration had
been removed from the persistence.
Now the boolean field is being set before any persistence calls actually
happen, which is a problem if any of the calls throw.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drewbrokke/felix patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit 25260a6b84438722de67b688b1af8713dcabe13a
Author: Drew Brokke <[email protected]>
Date: 2017-07-19T19:38:27Z
Fixes regression caused by FELIX-1488
If one of the three calls inside of the `delete()` method throws an
exception, the `isDeleted` field remains true, which causes some unexpected
`IllegalStateException`s.
Before the field was introduced, whenever the `isDeleted()` method was
called it would invoke `getPersistenceManager()`, which would then use the
local persistence manager to actually check to see if the configuration had
been removed from the persistence.
Now the boolean field is being set before any persistence calls actually
happen, which is a problem if any of the calls throw.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
