[
https://issues.apache.org/jira/browse/FELIX-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444241#comment-16444241
]
ASF GitHub Bot commented on FELIX-5832:
---------------------------------------
GitHub user cgdrake opened a pull request:
https://github.com/apache/felix/pull/134
[FELIX-5832] Only handle ConfigurationEvents for config objects managed by
us
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cgdrake/felix bugfix/FELIX-5832
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
----
> ConfigInstaller should only handle events for configurations it manages
> -----------------------------------------------------------------------
>
> Key: FELIX-5832
> URL: https://issues.apache.org/jira/browse/FELIX-5832
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-3.6.0, fileinstall-3.6.2
> Reporter: Chris Drake
> Priority: Major
> Attachments: ConfigInstaller.diff
>
>
> Recent changes introduced by FELIX-5609 have caused ConfigInstaller to
> incorrectly write configuration objets which it does not manage to disk.
> For example, given:
> {code:java}
> felix.fileinstall.filter=.*\\.cfg|.*\\.json{code}
> and a CustomConfigInstaller implementing the ArtifactInstaller and
> ConfigurationListener interfaces for .json configuration files, the
> expectation is that .cfg files will be installed and written back to disk by
> Felix's ConfigInstaller. Any .json configuration files will be installed and
> written to disk by the CustomConfigInstaller. Unfortunately since FileInstall
> 3.6.0, .json config files written to disk by the CustomConfigInstaller are
> overwritten by Felix's own ConfigInstaller.
> The regression is caused by a change to the ConfigInstaller, whereby
> ConfigurationEvents for _*all configuration objects*_ are handled as apposed
> to previous behaviour where only those configuration objects managed by the
> Felix ConfigInstaller (aka .cfg and .config) are managed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
