[
https://issues.apache.org/jira/browse/FELIX-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476379#comment-16476379
]
ASF GitHub Bot commented on FELIX-5850:
---------------------------------------
Github user jbonofre closed the pull request at:
https://github.com/apache/felix/pull/137
> ResourceBuilder should do deal with null bundle manifest version
> ----------------------------------------------------------------
>
> Key: FELIX-5850
> URL: https://issues.apache.org/jira/browse/FELIX-5850
> Project: Felix
> Issue Type: Bug
> Components: Utils
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: utils-1.11.2
>
>
> The {{ResourceBuilder#doBuild}} should deal with empty (null) bundle manifest
> version.
> We should do:
> {code}
> private static String getBundleManifestVersion(Map<String, String>
> headerMap) {
> return headerMap.get(Constants.BUNDLE_MANIFESTVERSION);
> }
> ...
> // Verify that only manifest version 2 is specified.
> String manifestVersion = getBundleManifestVersion(headerMap);
> if (!"2".equals(manifestVersion)) {
> throw new BundleException("Bundle-ManifestVersion must be 2 but
> is: " + manifestVersion);
> }
> {code}
> I will provide a PR (and test with Karaf itest).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
