[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749575#comment-16749575
]
ASF GitHub Bot commented on FELIX-6034:
---------------------------------------
GitHub user jbonofre opened a pull request:
https://github.com/apache/felix/pull/169
[FELIX-6034] Remove Requirement from Gogo JLine
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbonofre/felix FELIX-6034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 0232e90938528333cf1e4a74adf8d372778d8ed5
Author: Paul McCulloch <paul.mcculloch@...>
Date: 2018-10-17T15:34:26Z
FELIX-5968 Posix 'ls' command ignores .. unless -a is specified
FELIX-5968
Posix 'ls' command ignores .. unless -a is specified
commit b8468b585a4d3b806cd0f2305b27c92b10b00473
Author: Jean-Baptiste Onofré <jbonofre@...>
Date: 2019-01-22T14:16:14Z
[FELIX-6030] Remove @Header on Gogo JLine Activator to avoid issue in
Apache Karaf shell
commit 9cabff641bd7cea4b606d0ee3251cd44ba8e289c
Author: Jean-Baptiste Onofré <jbonofre@...>
Date: 2019-01-22T14:20:25Z
[FELIX-5963] Use named ExecutorService
commit bdb9fe5c0a84cacf198ffddc48dd14332cbe8125
Author: jbonofre <jbonofre@...>
Date: 2019-01-22T14:36:59Z
[FELIX-5963] This closes #168
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851825
13f79535-47bb-0310-9956-ffa450edef68
commit 960943684003e763669bb662d6c220702602446c
Author: jbonofre <jbonofre@...>
Date: 2019-01-22T14:40:53Z
[FELIX-5968] This closes #158
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851826
13f79535-47bb-0310-9956-ffa450edef68
commit 4a4df4950e045eb7bcebf2c5fc9d8fc8b6cd8b6f
Author: jbonofre <jbonofre@...>
Date: 2019-01-22T14:54:54Z
[FELIX-6030] This closes #167
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851828
13f79535-47bb-0310-9956-ffa450edef68
commit 58c69580de5385b7ebd018f9abe56270779d7b97
Author: Jean-Baptiste Onofré <jbonofre@...>
Date: 2019-01-22T14:06:10Z
[FELIX-6033] Align Felix Gogo wc posix action compliant with concrete posix
one
commit 0485eaf87c1237b7ab724cfd67fa1529697558b9
Author: jbonofre <jbonofre@...>
Date: 2019-01-22T16:25:39Z
[FELIX-6033] This closes #166
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1851830
13f79535-47bb-0310-9956-ffa450edef68
commit db0db44b5bdb798ae0d309fe0414b390f63552da
Author: Jean-Baptiste Onofré <jbonofre@...>
Date: 2019-01-23T06:52:28Z
[FELIX-6034] Remove Requirement from Gogo JLine
----
> Gogo JLine requirement doesn't allow to embed gogo.jline
> --------------------------------------------------------
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
> Affects Versions: gogo.jline-1.1.2
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
