[
https://issues.apache.org/jira/browse/FELIX-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751195#comment-16751195
]
Raymond Augé commented on FELIX-6034:
-------------------------------------
Ok guys, you convinced me that it was wrong to add the requirement in a micro
release. Granted. Sorry for the trouble that caused.
But let me explain my thoughts on the requirements for the future:
Gogo is comprised of a love triangle which, without each of the three elements,
is incomplete.
Any combination of runtime, shell, command is useless (I'm not talking about
bundles, I'm talking about feature wise).
However this doesn't mean each bundle cannot be used separately in different
types of deployments or recomposed into less than 3 bundles. The key is
ensuring that a system is complete at runtime in a way that is simple for
developers.
If I may ask a question about Karaf's custom jline (shell), is it that it
provides it's own fundamental commands (command)?
If so, isn't it self satisfying the requirement? The solution is then to simply
provide the capability to indicate self satisfy.
{{Provide-Capability:
org.apache.felix.gogo;org.apache.felix.gogo=command.implementation;version:Version="1.0.0"}}
> Gogo JLine requirement doesn't allow to embed gogo.jline
> --------------------------------------------------------
>
> Key: FELIX-6034
> URL: https://issues.apache.org/jira/browse/FELIX-6034
> Project: Felix
> Issue Type: Bug
> Components: Gogo JLine
> Affects Versions: gogo.jline-1.1.2
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: gogo.jline-1.1.3
>
>
> Felix Gogo Jline 1.1.2 introduced a Requirement:
> {code}
> @Requirement(
> effective = "active",
> namespace = "org.apache.felix.gogo",
> name = "command.implementation",
> version = "1.0.0"
> )
> {code}
> This requirement is a contract to find concrete command. However, in the case
> of Gogo JLine embedded as a standalone bundle, waiting for commands
> implementation (later on), this requirement doesn't allow to start. That's
> the case in Apache Karaf shell.
> [~rotty3000] do you mind if I remove this requirement (as I did other fixes
> like in {{Posix}} commands) ? We could add this Requirement in gogo.jline 2.x
> and then, I will have to find a bypass or at least a fake command providing a
> capability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
